Firestore: query_engine.test.ts: fix logic that checks configureCsi
#7501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsNo changes between base commit (503ca1e) and merge commit (5f2747d).Test Logs |
|
FYI I asked about the "Test Auth / Test Auth on Firefox If Changed" action failure: https://chat.google.com/room/AAAAWxMm_lQ/LWD9bSZiJrI. It appears that the workflow may need to be updated. |
Size Analysis Report 1Affected ProductsNo changes between base commit (503ca1e) and merge commit (5f2747d).Test Logs |
wu-hui
approved these changes
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests in
query_engine.test.tsare parameterized on aconfigureCsiboolean variable. Some tests are if anif (configureCsi)block, some are in anif (!configureCsi)block, and others are in neither, and run for both values ofconfigureCsi. However, the entire test suite was inside theif (!configureCsi)block, nesting the checks forif (configureCsi)which would unconditionally evaluate to false, causing those tests to never be run. This was likely a coding accident due to the subtle indenting difference.This PR fixes this by putting the
if (configureCsi),if (!configureCsi), and the other block at the same nesting level so that the appropriate tests are run for the appropriate values ofconfigureCsi.Note to reviewers: Turn off whitespace when looking at the diff, since the vast majority of lines affected by this PR are whitespace-only changes due to indentation level changes.