Update testing emulator to 1.18.1 #7445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkDuckworth
requested review from
dwyfrequency,
hsubox76 and
a team
as code owners
|
Size Report 1Affected ProductsNo changes between base commit (b60b73d) and merge commit (0ecf675).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (b60b73d) and merge commit (0ecf675).Test Logs |
tom-andersen
approved these changes
Jul 12, 2023
tom-andersen
deleted the
markduckworth/x-goog-request-params-emulator-update
branch
tom-andersen
added a commit
that referenced
this pull request
Jul 17, 2023
* Add `x-goog-request-params` to request header. * Create eighty-roses-appear.md * Pretty * Fix * Pretty * Pretty * Pretty * Failing CI fix (maybe) * Fix test * Fix test * Complete solution * Complete solution * Update testing emulator to 1.18.1 (#7445) * Attempt to make backward compatible with emulator. * Pretty * Pretty * Improve changeset message. * Encode values on 'x-goog-request-params' header. * Try slightly older version of emulator will pass auth test. * Revert emulator change --------- Co-authored-by: Mark Duckworth <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.