Skip to content

Firestore: Fix 'where indexeddb is not available' tests that were broken by persistence changes #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jul 5, 2023

The tests 'fails with code unimplemented' and 'falls back without requiring a wait for the promise' tests in indexeddb.test.ts were broken by #7404, which changed the way that "persistence" was tracked in the integration tests. These test failures were not noticed because they don't get executed by CI. This PR fixes the tests by providing a means to not explicitly specify a localCache in FirestoreSettings and instead use the implicit default, which is required by these tests.

@dconeybe dconeybe self-assigned this Jul 5, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

⚠️ No Changeset found

Latest commit: 463cae8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 5, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 5, 2023

@dconeybe dconeybe marked this pull request as ready for review July 5, 2023 19:01
@dconeybe dconeybe requested review from a team as code owners July 5, 2023 19:01
@dconeybe dconeybe requested a review from milaGGL July 5, 2023 19:02
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dconeybe dconeybe merged commit 684bb4e into master Jul 5, 2023
@dconeybe dconeybe deleted the dconeybe/PersistenceTestGeneralizationTestFix branch July 5, 2023 23:18
@firebase firebase locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants