Fix an issue where localCache is not copied as part of Settings #7385

wu-hui · 2023-06-22T16:08:26Z

Also fixes some public api to use the right classes

changeset-bot · 2023-06-22T16:08:30Z

🦋 Changeset detected

Latest commit: 2a2b57b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2023-06-22T16:38:55Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (85ccb2e) Merge (d33b2f7) Diff
browser 370 kB 370 kB +30 B (+0.0%)
esm5 356 kB 356 kB +30 B (+0.0%)
main 568 kB 568 kB +30 B (+0.0%)
module 370 kB 370 kB +30 B (+0.0%)
react-native 370 kB 370 kB +30 B (+0.0%)
@firebase/firestore-lite
Type Base (85ccb2e) Merge (d33b2f7) Diff
browser 110 kB 110 kB +5 B (+0.0%)
esm5 106 kB 106 kB +5 B (+0.0%)
main 151 kB 151 kB +5 B (+0.0%)
module 110 kB 110 kB +5 B (+0.0%)
react-native 110 kB 110 kB +5 B (+0.0%)

`bundle`

12 size changes

Type	Base (`85ccb2e`)	Merge (`d33b2f7`)	Diff
firestore (Persistence)	301 kB	301 kB	+30 B (+0.0%)
firestore (Query Cursors)	238 kB	238 kB	+30 B (+0.0%)
firestore (Query)	236 kB	236 kB	+30 B (+0.0%)
firestore (Read data once)	223 kB	223 kB	+30 B (+0.0%)
firestore (Realtime updates)	226 kB	226 kB	+30 B (+0.0%)
firestore (Transaction)	202 kB	202 kB	+30 B (+0.0%)
firestore (Write data)	202 kB	202 kB	+30 B (+0.0%)
firestore-lite (Query Cursors)	82.9 kB	82.9 kB	+5 B (+0.0%)
firestore-lite (Query)	79.0 kB	79.0 kB	+5 B (+0.0%)
firestore-lite (Read data once)	61.1 kB	61.1 kB	+5 B (+0.0%)
firestore-lite (Transaction)	85.9 kB	85.9 kB	+5 B (+0.0%)
firestore-lite (Write data)	70.6 kB	70.6 kB	+5 B (+0.0%)

`firebase`

Type	Base (`85ccb2e`)	Merge (`d33b2f7`)	Diff
firebase-compat.js	773 kB	773 kB	+30 B (+0.0%)
firebase-firestore-compat.js	339 kB	339 kB	+30 B (+0.0%)
firebase-firestore-lite.js	117 kB	117 kB	+5 B (+0.0%)
firebase-firestore.js	429 kB	430 kB	+30 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/b8oGYyRoPx.html

google-oss-bot · 2023-06-22T16:54:00Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- AbstractUserDataWriter
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 25.7 kB 25.7 kB +30 B (+0.1%)
  size-with-ext-deps 95.4 kB 95.4 kB +30 B (+0.0%)
- AggregateField
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.8 kB 17.8 kB +30 B (+0.2%)
  size-with-ext-deps 87.4 kB 87.4 kB +30 B (+0.0%)
- AggregateQuerySnapshot
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.8 kB 17.9 kB +30 B (+0.2%)
  size-with-ext-deps 87.4 kB 87.5 kB +30 B (+0.0%)
- Bytes
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 19.2 kB 19.2 kB +30 B (+0.2%)
  size-with-ext-deps 88.8 kB 88.8 kB +30 B (+0.0%)
- CACHE_SIZE_UNLIMITED
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.3 kB +30 B (+0.0%)
- CollectionReference
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 21.3 kB 21.3 kB +30 B (+0.1%)
  size-with-ext-deps 90.9 kB 90.9 kB +30 B (+0.0%)
- DocumentReference
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 21.2 kB 21.3 kB +30 B (+0.1%)
  size-with-ext-deps 90.9 kB 90.9 kB +30 B (+0.0%)
- DocumentSnapshot
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 24.7 kB 24.8 kB +30 B (+0.1%)
  size-with-ext-deps 94.4 kB 94.4 kB +30 B (+0.0%)
- FieldPath
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 20.3 kB 20.4 kB +30 B (+0.1%)
  size-with-ext-deps 90.0 kB 90.0 kB +30 B (+0.0%)
- FieldValue
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.3 kB +30 B (+0.0%)
- Firestore
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.2 kB 87.3 kB +30 B (+0.0%)
- FirestoreError
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.3 kB +30 B (+0.0%)
- GeoPoint
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.2 kB 18.3 kB +30 B (+0.2%)
  size-with-ext-deps 87.8 kB 87.9 kB +30 B (+0.0%)
- LoadBundleTask
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.5 kB 18.5 kB +30 B (+0.2%)
  size-with-ext-deps 88.1 kB 88.1 kB +30 B (+0.0%)
- Query
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.8 kB 17.8 kB +30 B (+0.2%)
  size-with-ext-deps 87.4 kB 87.4 kB +30 B (+0.0%)
- QueryCompositeFilterConstraint
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 20.9 kB 21.0 kB +30 B (+0.1%)
  size-with-ext-deps 90.6 kB 90.6 kB +30 B (+0.0%)
- QueryConstraint
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.3 kB +30 B (+0.0%)
- QueryDocumentSnapshot
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 24.7 kB 24.8 kB +30 B (+0.1%)
  size-with-ext-deps 94.4 kB 94.4 kB +30 B (+0.0%)
- QueryEndAtConstraint
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 36.5 kB 36.5 kB +30 B (+0.1%)
  size-with-ext-deps 106 kB 106 kB +30 B (+0.0%)
- QueryFieldFilterConstraint
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 42.2 kB 42.2 kB +30 B (+0.1%)
  size-with-ext-deps 112 kB 112 kB +30 B (+0.0%)
- QueryLimitConstraint
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.4 kB 18.5 kB +30 B (+0.2%)
  size-with-ext-deps 88.0 kB 88.1 kB +30 B (+0.0%)
- QueryOrderByConstraint
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 19.5 kB 19.5 kB +30 B (+0.2%)
  size-with-ext-deps 89.1 kB 89.1 kB +30 B (+0.0%)
- QuerySnapshot
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 26.7 kB 26.7 kB +30 B (+0.1%)
  size-with-ext-deps 96.3 kB 96.3 kB +30 B (+0.0%)
- QueryStartAtConstraint
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 36.5 kB 36.5 kB +30 B (+0.1%)
  size-with-ext-deps 106 kB 106 kB +30 B (+0.0%)
- SnapshotMetadata
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.8 kB 17.8 kB +30 B (+0.2%)
  size-with-ext-deps 87.4 kB 87.4 kB +30 B (+0.0%)
- Timestamp
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.8 kB 18.9 kB +30 B (+0.2%)
  size-with-ext-deps 88.4 kB 88.5 kB +30 B (+0.0%)
- Transaction
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 51.4 kB 51.5 kB +30 B (+0.1%)
  size-with-ext-deps 121 kB 121 kB +30 B (+0.0%)
- WriteBatch
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 48.2 kB 48.2 kB +30 B (+0.1%)
  size-with-ext-deps 118 kB 118 kB +30 B (+0.0%)
- _DatabaseId
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.2 kB 87.3 kB +30 B (+0.0%)
- _DocumentKey
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 26.9 kB 27.0 kB +30 B (+0.1%)
  size-with-ext-deps 96.6 kB 96.6 kB +30 B (+0.0%)
- _EmptyAppCheckTokenProvider
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.8 kB 17.8 kB +30 B (+0.2%)
  size-with-ext-deps 87.4 kB 87.4 kB +30 B (+0.0%)
- _EmptyAuthCredentialsProvider
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.3 kB +30 B (+0.0%)
- _FieldPath
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 20.1 kB 20.1 kB +30 B (+0.1%)
  size-with-ext-deps 89.7 kB 89.7 kB +30 B (+0.0%)
- _TestingHooks
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.1 kB 18.1 kB +30 B (+0.2%)
  size-with-ext-deps 87.7 kB 87.7 kB +30 B (+0.0%)
- _cast
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.4 kB 18.5 kB +30 B (+0.2%)
  size-with-ext-deps 88.0 kB 88.1 kB +30 B (+0.0%)
- _debugAssert
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.3 kB +30 B (+0.0%)
- _isBase64Available
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.3 kB +30 B (+0.0%)
- _logWarn
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.8 kB 17.8 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.4 kB +30 B (+0.0%)
- _validateIsNotUsedTogether
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.3 kB +30 B (+0.0%)
- addDoc
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 122 kB 122 kB +30 B (+0.0%)
  size-with-ext-deps 192 kB 192 kB +30 B (+0.0%)
- aggregateFieldEqual
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.0 kB 18.1 kB +30 B (+0.2%)
  size-with-ext-deps 87.6 kB 87.6 kB +30 B (+0.0%)
- aggregateQuerySnapshotEqual
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 34.0 kB 34.0 kB +30 B (+0.1%)
  size-with-ext-deps 104 kB 104 kB +30 B (+0.0%)
- and
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 43.6 kB 43.7 kB +30 B (+0.1%)
  size-with-ext-deps 113 kB 113 kB +30 B (+0.0%)
- arrayRemove
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 30.4 kB 30.4 kB +30 B (+0.1%)
  size-with-ext-deps 100 kB 100 kB +30 B (+0.0%)
- arrayUnion
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 30.4 kB 30.4 kB +30 B (+0.1%)
  size-with-ext-deps 100 kB 100 kB +30 B (+0.0%)
- average
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 21.3 kB 21.4 kB +30 B (+0.1%)
  size-with-ext-deps 91.0 kB 91.0 kB +30 B (+0.0%)
- clearIndexedDbPersistence
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 26.4 kB 26.5 kB +30 B (+0.1%)
  size-with-ext-deps 96.2 kB 96.2 kB +30 B (+0.0%)
- collection
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 22.0 kB 22.0 kB +30 B (+0.1%)
  size-with-ext-deps 91.6 kB 91.7 kB +30 B (+0.0%)
- collectionGroup
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 21.0 kB 21.0 kB +30 B (+0.1%)
  size-with-ext-deps 90.6 kB 90.6 kB +30 B (+0.0%)
- connectFirestoreEmulator
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 19.5 kB 19.5 kB +30 B (+0.2%)
  size-with-ext-deps 89.7 kB 89.7 kB +30 B (+0.0%)
- count
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.8 kB 17.8 kB +30 B (+0.2%)
  size-with-ext-deps 87.4 kB 87.4 kB +30 B (+0.0%)
- deleteDoc
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 113 kB 113 kB +30 B (+0.0%)
  size-with-ext-deps 183 kB 183 kB +30 B (+0.0%)
- deleteField
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.0 kB 18.1 kB +30 B (+0.2%)
  size-with-ext-deps 87.6 kB 87.7 kB +30 B (+0.0%)
- disableNetwork
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 101 kB 101 kB +30 B (+0.0%)
  size-with-ext-deps 171 kB 171 kB +30 B (+0.0%)
- doc
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 22.0 kB 22.1 kB +30 B (+0.1%)
  size-with-ext-deps 91.7 kB 91.7 kB +30 B (+0.0%)
- documentId
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 20.4 kB 20.4 kB +30 B (+0.1%)
  size-with-ext-deps 90.0 kB 90.0 kB +30 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 183 kB 183 kB +30 B (+0.0%)
  size-with-ext-deps 255 kB 255 kB +30 B (+0.0%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 220 kB 220 kB +30 B (+0.0%)
  size-with-ext-deps 292 kB 292 kB +30 B (+0.0%)
- enableNetwork
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 101 kB 101 kB +30 B (+0.0%)
  size-with-ext-deps 171 kB 171 kB +30 B (+0.0%)
- endAt
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 36.5 kB 36.6 kB +30 B (+0.1%)
  size-with-ext-deps 106 kB 106 kB +30 B (+0.0%)
- endBefore
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 36.5 kB 36.6 kB +30 B (+0.1%)
  size-with-ext-deps 106 kB 106 kB +30 B (+0.0%)
- ensureFirestoreConfigured
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.8 kB 17.8 kB +30 B (+0.2%)
  size-with-ext-deps 87.4 kB 87.4 kB +30 B (+0.0%)
- executeWrite
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 112 kB 112 kB +30 B (+0.0%)
  size-with-ext-deps 182 kB 182 kB +30 B (+0.0%)
- getAggregateFromServer
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 108 kB 108 kB +30 B (+0.0%)
  size-with-ext-deps 178 kB 178 kB +30 B (+0.0%)
- getCountFromServer
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 108 kB 108 kB +30 B (+0.0%)
  size-with-ext-deps 179 kB 179 kB +30 B (+0.0%)
- getDoc
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 143 kB 143 kB +30 B (+0.0%)
  size-with-ext-deps 213 kB 213 kB +30 B (+0.0%)
- getDocFromCache
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 93.6 kB 93.6 kB +30 B (+0.0%)
  size-with-ext-deps 163 kB 163 kB +30 B (+0.0%)
- getDocFromServer
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 143 kB 143 kB +30 B (+0.0%)
  size-with-ext-deps 213 kB 213 kB +30 B (+0.0%)
- getDocs
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 144 kB 144 kB +30 B (+0.0%)
  size-with-ext-deps 215 kB 215 kB +30 B (+0.0%)
- getDocsFromCache
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 101 kB 101 kB +30 B (+0.0%)
  size-with-ext-deps 171 kB 171 kB +30 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 144 kB 144 kB +30 B (+0.0%)
  size-with-ext-deps 215 kB 215 kB +30 B (+0.0%)
- getFirestore
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 19.8 kB 19.8 kB +30 B (+0.2%)
  size-with-ext-deps 97.5 kB 97.6 kB +30 B (+0.0%)
- increment
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.5 kB 18.6 kB +30 B (+0.2%)
  size-with-ext-deps 88.1 kB 88.2 kB +30 B (+0.0%)
- initializeFirestore
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.6 kB 18.6 kB +30 B (+0.2%)
  size-with-ext-deps 88.7 kB 88.7 kB +30 B (+0.0%)
- limit
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.6 kB 18.6 kB +30 B (+0.2%)
  size-with-ext-deps 88.2 kB 88.2 kB +30 B (+0.0%)
- limitToLast
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.6 kB 18.7 kB +30 B (+0.2%)
  size-with-ext-deps 88.2 kB 88.3 kB +30 B (+0.0%)
- loadBundle
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 111 kB 111 kB +30 B (+0.0%)
  size-with-ext-deps 181 kB 181 kB +30 B (+0.0%)
- memoryEagerGarbageCollector
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 84.1 kB 84.2 kB +30 B (+0.0%)
  size-with-ext-deps 154 kB 154 kB +30 B (+0.0%)
- memoryLocalCache
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 98.2 kB 98.2 kB +30 B (+0.0%)
  size-with-ext-deps 168 kB 168 kB +30 B (+0.0%)
- memoryLruGarbageCollector
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 90.6 kB 90.7 kB +30 B (+0.0%)
  size-with-ext-deps 160 kB 161 kB +30 B (+0.0%)
- namedQuery
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 87.0 kB 87.1 kB +30 B (+0.0%)
  size-with-ext-deps 157 kB 157 kB +30 B (+0.0%)
- onSnapshot
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 145 kB 145 kB +30 B (+0.0%)
  size-with-ext-deps 215 kB 215 kB +30 B (+0.0%)
- onSnapshotsInSync
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 134 kB 135 kB +30 B (+0.0%)
  size-with-ext-deps 205 kB 205 kB +30 B (+0.0%)
- or
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 43.6 kB 43.7 kB +30 B (+0.1%)
  size-with-ext-deps 113 kB 113 kB +30 B (+0.0%)
- orderBy
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 23.0 kB 23.0 kB +30 B (+0.1%)
  size-with-ext-deps 92.6 kB 92.6 kB +30 B (+0.0%)
- persistentLocalCache
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 181 kB 181 kB +30 B (+0.0%)
  size-with-ext-deps 252 kB 252 kB +30 B (+0.0%)
- persistentMultipleTabManager
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 217 kB 217 kB +30 B (+0.0%)
  size-with-ext-deps 289 kB 289 kB +30 B (+0.0%)
- persistentSingleTabManager
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 180 kB 180 kB +30 B (+0.0%)
  size-with-ext-deps 252 kB 252 kB +30 B (+0.0%)
- query
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 43.9 kB 43.9 kB +30 B (+0.1%)
  size-with-ext-deps 114 kB 114 kB +30 B (+0.0%)
- queryEqual
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 33.9 kB 33.9 kB +30 B (+0.1%)
  size-with-ext-deps 104 kB 104 kB +30 B (+0.0%)
- refEqual
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 21.4 kB 21.5 kB +30 B (+0.1%)
  size-with-ext-deps 91.1 kB 91.1 kB +30 B (+0.0%)
- runTransaction
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 122 kB 122 kB +30 B (+0.0%)
  size-with-ext-deps 192 kB 192 kB +30 B (+0.0%)
- serverTimestamp
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 18.0 kB 18.0 kB +30 B (+0.2%)
  size-with-ext-deps 87.6 kB 87.6 kB +30 B (+0.0%)
- setDoc
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 121 kB 121 kB +30 B (+0.0%)
  size-with-ext-deps 191 kB 191 kB +30 B (+0.0%)
- setIndexConfiguration
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 89.7 kB 89.7 kB +30 B (+0.0%)
  size-with-ext-deps 160 kB 160 kB +30 B (+0.0%)
- setLogLevel
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.7 kB 17.7 kB +30 B (+0.2%)
  size-with-ext-deps 87.3 kB 87.3 kB +30 B (+0.0%)
- snapshotEqual
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 39.6 kB 39.6 kB +30 B (+0.1%)
  size-with-ext-deps 109 kB 109 kB +30 B (+0.0%)
- startAfter
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 36.5 kB 36.6 kB +30 B (+0.1%)
  size-with-ext-deps 106 kB 106 kB +30 B (+0.0%)
- startAt
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 36.5 kB 36.6 kB +30 B (+0.1%)
  size-with-ext-deps 106 kB 106 kB +30 B (+0.0%)
- sum
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 21.3 kB 21.4 kB +30 B (+0.1%)
  size-with-ext-deps 91.0 kB 91.0 kB +30 B (+0.0%)
- terminate
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 17.8 kB 17.8 kB +30 B (+0.2%)
  size-with-ext-deps 87.6 kB 87.6 kB +30 B (+0.0%)
- updateDoc
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 122 kB 122 kB +30 B (+0.0%)
  size-with-ext-deps 192 kB 192 kB +30 B (+0.0%)
- waitForPendingWrites
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 102 kB 102 kB +30 B (+0.0%)
  size-with-ext-deps 172 kB 172 kB +30 B (+0.0%)
- where
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 43.0 kB 43.0 kB +30 B (+0.1%)
  size-with-ext-deps 113 kB 113 kB +30 B (+0.0%)
- writeBatch
  Size
  Type Base (85ccb2e) Merge (d33b2f7) Diff
  size 123 kB 124 kB +30 B (+0.0%)
  size-with-ext-deps 194 kB 194 kB +30 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/hfyf739k0D.html

MarkDuckworth

LGTM. As far as I can tell, there's no public API change. Is that right?

wu-hui · 2023-06-26T17:19:10Z

LGTM. As far as I can tell, there's no public API change. Is that right?

Yep, that is right.

wu-hui · 2023-06-26T17:25:56Z

@markarndt Please review the release note, there is also some minor fixes on public docs, some non-existent classes were incorrectly mentioned in the public ref doc.

ocavue · 2023-07-07T07:30:09Z

@wu-hui I apologize for mentioning you in a closed pull request. I noticed this change in the recent v10.0.0 changelog, and I'm having a bit of difficulty understanding the full impact of this bug. Could you kindly clarify whether this means the localCache configuration in an application using the previous major version Firebase (v9.23.0) wasn't effective? Thank you for your assistance!

wu-hui · 2023-07-07T14:14:53Z

@wu-hui I apologize for mentioning you in a closed pull request. I noticed this change in the recent v10.0.0 changelog, and I'm having a bit of difficulty understanding the full impact of this bug. Could you kindly clarify whether this means the localCache configuration in an application using the previous major version Firebase (v9.23.0) wasn't effective? Thank you for your assistance!

The issue is if you call connectEmulator after you set localCache, the localCache value is ignored by the SDK. This should only happen in your testing code.

wu-hui requested review from egilmorez, markarndt, kevinthecheung and a team as code owners June 22, 2023 16:08

wu-hui added 2 commits June 22, 2023 12:12

add test

5874258

Fix a bug where localCache is not copied as part of Settings

3ea1c10

wu-hui force-pushed the wuandy/PersistentCacheWithEmulator branch from 8ee1650 to 3ea1c10 Compare June 22, 2023 16:14

wu-hui and others added 2 commits June 22, 2023 12:18

Remove debug logging

5b584ad

Create eighty-tomatoes-trade.md

2a2b57b

wu-hui requested a review from a team as a code owner June 22, 2023 16:24

wu-hui requested a review from MarkDuckworth June 22, 2023 17:19

wu-hui assigned MarkDuckworth Jun 22, 2023

MarkDuckworth approved these changes Jun 26, 2023

View reviewed changes

wu-hui assigned markarndt and unassigned MarkDuckworth Jun 26, 2023

markarndt approved these changes Jun 26, 2023

View reviewed changes

wu-hui merged commit aaf3fa3 into master Jun 26, 2023

wu-hui deleted the wuandy/PersistentCacheWithEmulator branch June 26, 2023 18:01

google-oss-bot mentioned this pull request Jul 6, 2023

Version Packages #7421

Merged

firebase locked and limited conversation to collaborators Jul 27, 2023

Fix an issue where localCache is not copied as part of Settings #7385

Fix an issue where localCache is not copied as part of Settings #7385

Conversation

wu-hui commented Jun 22, 2023 • edited Loading

changeset-bot bot commented Jun 22, 2023 • edited Loading

🦋 Changeset detected

google-oss-bot commented Jun 22, 2023 • edited Loading

Size Report 1

Affected Products

@firebase/firestore

@firebase/firestore-lite

bundle

firebase

Test Logs

google-oss-bot commented Jun 22, 2023 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/firestore

AbstractUserDataWriter

AggregateField

AggregateQuerySnapshot

Bytes

CACHE_SIZE_UNLIMITED

CollectionReference

DocumentReference

DocumentSnapshot

FieldPath

FieldValue

Firestore

FirestoreError

GeoPoint

LoadBundleTask

Query

QueryCompositeFilterConstraint

QueryConstraint

QueryDocumentSnapshot

QueryEndAtConstraint

QueryFieldFilterConstraint

QueryLimitConstraint

QueryOrderByConstraint

QuerySnapshot

QueryStartAtConstraint

SnapshotMetadata

Timestamp

Transaction

WriteBatch

_DatabaseId

_DocumentKey

_EmptyAppCheckTokenProvider

_EmptyAuthCredentialsProvider

_FieldPath

_TestingHooks

_cast

_debugAssert

_isBase64Available

_logWarn

_validateIsNotUsedTogether

addDoc

aggregateFieldEqual

aggregateQuerySnapshotEqual

and

arrayRemove

arrayUnion

average

clearIndexedDbPersistence

collection

collectionGroup

connectFirestoreEmulator

count

deleteDoc

deleteField

disableNetwork

doc

documentId

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

endAt

endBefore

ensureFirestoreConfigured

wu-hui commented Jun 22, 2023 •

edited

Loading

changeset-bot bot commented Jun 22, 2023 •

edited

Loading

google-oss-bot commented Jun 22, 2023 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Jun 22, 2023 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`AbstractUserDataWriter`

`AggregateField`

`AggregateQuerySnapshot`

`Bytes`

`CACHE_SIZE_UNLIMITED`

`CollectionReference`

`DocumentReference`

`DocumentSnapshot`

`FieldPath`

`FieldValue`

`Firestore`

`FirestoreError`

`GeoPoint`

`LoadBundleTask`

`Query`

`QueryCompositeFilterConstraint`

`QueryConstraint`

`QueryDocumentSnapshot`

`QueryEndAtConstraint`

`QueryFieldFilterConstraint`

`QueryLimitConstraint`

`QueryOrderByConstraint`

`QuerySnapshot`

`QueryStartAtConstraint`

`SnapshotMetadata`

`Timestamp`

`Transaction`

`WriteBatch`

`_DatabaseId`

`_DocumentKey`

`_EmptyAppCheckTokenProvider`

`_EmptyAuthCredentialsProvider`

`_FieldPath`

`_TestingHooks`

`_cast`

`_debugAssert`

`_isBase64Available`

`_logWarn`

`_validateIsNotUsedTogether`

`addDoc`

`aggregateFieldEqual`

`aggregateQuerySnapshotEqual`

`and`

`arrayRemove`

`arrayUnion`

`average`

`clearIndexedDbPersistence`

`collection`

`collectionGroup`

`connectFirestoreEmulator`

`count`

`deleteDoc`

`deleteField`

`disableNetwork`

`doc`

`documentId`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`endAt`

`endBefore`

`ensureFirestoreConfigured`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`

`getDoc`

`getDocFromCache`

`getDocFromServer`

`getDocs`