Skip to content

Fix console log and error handling #7377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix console log and error handling #7377

merged 1 commit into from
Jun 21, 2023

Conversation

hsubox76
Copy link
Contributor

Seen some errors on the log for this job although it seems to complete fine. Try to catch the error (it says it's unhandled) and not stringify data until after the console.log line has read its properties.

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: 9cacb0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review June 20, 2023 21:33
@hsubox76 hsubox76 requested review from dwyfrequency and a team as code owners June 20, 2023 21:33
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit fe2ac13 into master Jun 21, 2023
@hsubox76 hsubox76 deleted the ch-fix-pr-logger branch June 21, 2023 16:31
@firebase firebase locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants