Skip to content

More logging and increase memory limit #7338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 31, 2023
Merged

More logging and increase memory limit #7338

merged 5 commits into from
May 31, 2023

Conversation

hsubox76
Copy link
Contributor

Trying a few more things to fix or diagnose staging problems.

  • bump memory limit in case memory is the issue (we do this on builds)
  • ensure it always spits out all logs if the "verbose" option is enabled

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

⚠️ No Changeset found

Latest commit: 42d09ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review May 30, 2023 21:21
@hsubox76 hsubox76 requested review from dwyfrequency and a team as code owners May 30, 2023 21:21
dwyfrequency
dwyfrequency approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (ce61896) and merge commit (757911d).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rakaZ95z2h.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (ce61896) and merge commit (757911d).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1ohLOLtaQA.html

@hsubox76 hsubox76 merged commit 2ccc9dd into master May 31, 2023
@hsubox76 hsubox76 deleted the ch-debug-staging branch May 31, 2023 16:37
@google-oss-bot google-oss-bot mentioned this pull request May 31, 2023
Merged
ch5zzy pushed a commit that referenced this pull request Jun 6, 2023
@hsubox76 @ch5zzy
More logging and increase memory limit (#7338)
f915687
dwyfrequency pushed a commit that referenced this pull request Jun 16, 2023
@hsubox76 @dwyfrequency
More logging and increase memory limit (#7338)
005866b
@firebase firebase locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @google-oss-bot @dwyfrequency @DellaBitta