Skip to content

Catch E2E log request errors #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

Catch E2E log request errors #7298

merged 1 commit into from
May 15, 2023

Conversation

hsubox76
Copy link
Contributor

Revert publish logs (too verbose), catch E2E log request errors.

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

⚠️ No Changeset found

Latest commit: caa3c9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 changed the title revert publish logs Catch E2E log request errors May 12, 2023
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (9c6f972) and merge commit (95ebcd4).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0hPfu59H06.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (9c6f972) and merge commit (95ebcd4).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/R3PFBNBeZi.html

@hsubox76 hsubox76 marked this pull request as ready for review May 15, 2023 17:09
@hsubox76 hsubox76 requested review from dwyfrequency and a team as code owners May 15, 2023 17:09
dwyfrequency
dwyfrequency approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit a9da1b7 into master May 15, 2023
@hsubox76 hsubox76 deleted the ch-notify-fix branch May 15, 2023 17:22
@firebase firebase locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @dwyfrequency