Skip to content

Try to log publish errors #7295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2023
Merged

Try to log publish errors #7295

merged 2 commits into from
May 12, 2023

Conversation

hsubox76
Copy link
Contributor

Try to ensure any errors in the spawn process that runs the npm publish command are sent to the console and not swallowed. May help debug problem publishing in staging:

https://github.com/firebase/firebase-js-sdk/actions/runs/4953536908/jobs/8861115245

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

⚠️ No Changeset found

Latest commit: 447f9a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review May 12, 2023 16:04
@hsubox76 hsubox76 requested review from dwyfrequency and a team as code owners May 12, 2023 16:04
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 merged commit 9c6f972 into master May 12, 2023
@hsubox76 hsubox76 deleted the ch-log-publish branch May 12, 2023 16:36
@google-oss-bot
Copy link
Contributor

@firebase firebase locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants