Skip to content

Firestore: Remove the no-android tag from bloom filter spec tests #7285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023
Merged

Firestore: Remove the no-android tag from bloom filter spec tests #7285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions packages/firestore/test/unit/specs/existence_filter_spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,8 @@ describeSpec('Existence Filters:', [], () => {
*/
specTest(
'Full re-query is skipped when bloom filter can identify documents deleted',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { v: 1 });
Expand Down Expand Up @@ -311,9 +310,8 @@ describeSpec('Existence Filters:', [], () => {

specTest(
'Full re-query is triggered when bloom filter can not identify documents deleted',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { v: 1 });
Expand Down Expand Up @@ -345,9 +343,8 @@ describeSpec('Existence Filters:', [], () => {

specTest(
'Bloom filter can process special characters in document name',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/ÀÒ∑', 1000, { v: 1 });
Expand Down Expand Up @@ -375,9 +372,8 @@ describeSpec('Existence Filters:', [], () => {

specTest(
'Bloom filter fills in default values for undefined padding and hashCount',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { v: 1 });
Expand Down Expand Up @@ -449,9 +445,8 @@ describeSpec('Existence Filters:', [], () => {

specTest(
'Full re-query is triggered when bloom filter hashCount is invalid',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { v: 1 });
Expand Down Expand Up @@ -485,9 +480,8 @@ describeSpec('Existence Filters:', [], () => {

specTest(
'Full re-query is triggered when bloom filter is empty',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { v: 1 });
Expand Down Expand Up @@ -522,9 +516,8 @@ describeSpec('Existence Filters:', [], () => {

specTest(
'Same documents can have different bloom filters',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection', filter('v', '<=', 2));
const query2 = query('collection', filter('v', '>=', 2));
Expand Down Expand Up @@ -574,9 +567,8 @@ describeSpec('Existence Filters:', [], () => {

specTest(
'Bloom filter is handled at global snapshot',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { v: 1 });
Expand Down Expand Up @@ -608,9 +600,8 @@ describeSpec('Existence Filters:', [], () => {

specTest(
'Bloom filter limbo resolution is denied',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { v: 1 });
Expand Down Expand Up @@ -640,9 +631,8 @@ describeSpec('Existence Filters:', [], () => {

specTest(
'Bloom filter with large size works as expected',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docs = [];
Expand Down
3 changes: 1 addition & 2 deletions packages/firestore/test/unit/specs/limbo_spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,9 +929,8 @@ describeSpec('Limbo Documents:', [], () => {

specTest(
'Limbo resolution throttling with bloom filter application',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA1 = doc('collection/a1', 1000, { key: 'a1' });
Expand Down
9 changes: 3 additions & 6 deletions packages/firestore/test/unit/specs/listen_spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,9 +1812,8 @@ describeSpec('Listens:', [], () => {

specTest(
'Resuming a query should specify expectedCount when adding the target',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { key: 'a' });
Expand Down Expand Up @@ -1848,9 +1847,8 @@ describeSpec('Listens:', [], () => {

specTest(
'Resuming a query should specify expectedCount that does not include pending mutations',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { key: 'a' });
Expand Down Expand Up @@ -1879,9 +1877,8 @@ describeSpec('Listens:', [], () => {

specTest(
'ExpectedCount in listen request should work after coming back online',
// TODO(b/278759194) Remove 'no-android' once bloom filter is merged.
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
['no-ios', 'no-android'],
['no-ios'],
() => {
const query1 = query('collection');
const docA = doc('collection/a', 1000, { key: 'a' });
Expand Down