Skip to content

Fix changeset wording for experimentalLongPollingOptions.timeoutSeconds #7281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented May 8, 2023

This changeset was created by #7176, but its wording neglected to update idleHttpRequestTimeoutSeconds to experimentalLongPollingOptions.timeoutSeconds. This commit fixes the wording to specify the correct property.

This changeset was created by #7176, but its wording neglected to update `idleHttpRequestTimeoutSeconds` to `experimentalLongPollingOptions.timeoutSeconds`. This commit fixes the wording to specify the correct property.
@dconeybe dconeybe requested a review from a team as a code owner May 8, 2023 15:16
@dconeybe dconeybe self-assigned this May 8, 2023
@dconeybe dconeybe requested review from a team as code owners May 8, 2023 15:16
@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

⚠️ No Changeset found

Latest commit: 66a8fb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
firebase Minor
@firebase/firestore-compat Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a . at the end of sentence.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@dconeybe dconeybe merged commit 61586af into master May 8, 2023
@dconeybe dconeybe deleted the dconeybe/ChangeLogFixForLongPollingTimeoutSeconds branch May 8, 2023 16:15
@firebase firebase locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants