Create issue template with required fields #7275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
DellaBitta
approved these changes
May 2, 2023
|
Just curious, is there a reason you made a separate file instead of modifying the existing one? |
Yes, I figured we would want to test/try it out in the repo before making it the official one. I added it to my nextjs testing repo https://github.com/dwyfrequency/next-platform-mvp-tests/blob/main/.github/ISSUE_TEMPLATE/bug_report.yaml so I am pretty confident but I thought it best to keep both for now until we finalize the V2 template. |
hsubox76
reviewed
May 4, 2023
| id: firebase-sdk-product | ||
| attributes: | ||
| label: Firebase SDK Product | ||
| description: Describe your Firebase SDK Product |
There was a problem hiding this comment.
Products,. People often are using multiple products. Maybe a dropdown or checkboxes would be good here, especially since the google-oss-bot auto-triages based on reading what's in this field. Actually we should try to find out what strings exactly the bot is looking for. I am not totally sure where the bot code lives, will try to look into it. If it's looking for "Firebase Product" which was in the old form, I guess we should leave the label the same. Also need to see what product strings it wants. If we stick with text input, let's put 2 packages in the placeholder example to show people they can do that.
hsubox76
approved these changes
May 5, 2023
| multiple: true | ||
| options: | ||
| - Analytics | ||
| - App-Check |
There was a problem hiding this comment.
nit: AppCheck is how we usually do it in human-readable text settings
| - type: dropdown | ||
| id: firebase-sdk-products | ||
| attributes: | ||
| label: Firebase SDK Products |
There was a problem hiding this comment.
Firebase SDK Product: unless you are going to change the regex.
| id: firebase-sdk-products | ||
| attributes: | ||
| label: Firebase SDK Products | ||
| description: What Firebase SDK Products is your app using? |
There was a problem hiding this comment.
"are"? I think? That also sounds awkward. "Which Firebase Products are used in your app?"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new issue template that specifies required fields