Skip to content

Add long-alias support for aggregations. #7244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 25, 2023

Conversation

MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023

⚠️ No Changeset found

Latest commit: 03c253b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2023

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (bddc177)Merge (55a8187)Diff
    browser285 kB285 kB-145 B (-0.1%)
    esm5354 kB354 kB-175 B (-0.0%)
    main566 kB566 kB+6 B (+0.0%)
    module285 kB285 kB-145 B (-0.1%)
    react-native285 kB285 kB-145 B (-0.1%)
  • @firebase/firestore-lite

    TypeBase (bddc177)Merge (55a8187)Diff
    browser87.7 kB87.5 kB-145 B (-0.2%)
    esm5106 kB105 kB-175 B (-0.2%)
    main149 kB149 kB+6 B (+0.0%)
    module87.7 kB87.5 kB-145 B (-0.2%)
    react-native87.8 kB87.7 kB-145 B (-0.2%)
  • firebase

    TypeBase (bddc177)Merge (55a8187)Diff
    firebase-firestore-lite.js94.4 kB94.2 kB-145 B (-0.2%)
    firebase-firestore.js344 kB344 kB-145 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mBNw2HdzT6.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2023

Size Analysis Report 1

This report is too large (638,604 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ekkyI9lIV3.html

@ehsannas ehsannas self-assigned this Apr 20, 2023
@ehsannas ehsannas self-requested a review April 20, 2023 22:33
@ehsannas
Copy link
Contributor

Not sure why CI is failing with Operator field in Aggregation is not set

@MarkDuckworth
Copy link
Contributor Author

@ehsannas, I made all of these changes. It took me a bit, but now I agree that this is a better approach. Thanks for your review.

@MarkDuckworth MarkDuckworth requested a review from ehsannas April 21, 2023 22:05
@MarkDuckworth MarkDuckworth requested review from a team as code owners April 25, 2023 15:17
@MarkDuckworth MarkDuckworth merged commit 51e4059 into markduckworth/sum-avg-3 Apr 25, 2023
@MarkDuckworth MarkDuckworth deleted the markduckworth/sum-avg-4 branch April 25, 2023 15:56
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants