Skip to content

Firestore: database.test.ts: add tests for coercing long polling settings to boolean #7242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 20, 2023
Merged

Firestore: database.test.ts: add tests for coercing long polling settings to boolean #7242

merged 5 commits into from
Apr 20, 2023

Conversation

dconeybe
Copy link
Contributor

Add Firestore unit tests for coercing experimentalForceLongPolling and experimentalAutoDetectLongPolling to boolean

@dconeybe
Firestore: database.test.ts: add tests for coercing experimentalForce…
3e2be99 
…LongPolling and experimentalAutoDetectLongPolling to boolean
@dconeybe dconeybe self-assigned this Apr 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f8994da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (0832dca) and merge commit (73394c7).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gQafhsLAiC.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (0832dca) and merge commit (73394c7).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/muNBz7L8J1.html

@dconeybe dconeybe mentioned this pull request Apr 20, 2023
Merged
@dconeybe dconeybe requested a review from tom-andersen April 20, 2023 17:43
@dconeybe dconeybe assigned tom-andersen and unassigned dconeybe Apr 20, 2023
tom-andersen
tom-andersen approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 61910bd into master Apr 20, 2023
@dconeybe dconeybe deleted the dconeybe/LongPollingCoerceToBooleanTests branch April 20, 2023 20:34
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @tom-andersen