Skip to content

Fix "Update API reports" workflow #7205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Fix "Update API reports" workflow #7205

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeefa1d
try ref instead of sha
hsubox76 Apr 6, 2023
e73c9f6
Update API reports
hsubox76 Apr 6, 2023
2c1b902
Trigger CI
hsubox76 Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-api-reports.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
uses: actions/checkout@master
with:
# checkout HEAD commit instead of merge commit
ref: ${{ github.event.pull_request.head.sha }}
ref: ${{ github.event.pull_request.head.ref }}
token: ${{ github.token }}
- name: Set up Node (14)
uses: actions/setup-node@v2
Expand Down
2 changes: 1 addition & 1 deletion common/api-review/auth.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ export interface TotpMultiFactorAssertion extends MultiFactorAssertion {
export class TotpMultiFactorGenerator {
static assertionForEnrollment(secret: TotpSecret, oneTimePassword: string): TotpMultiFactorAssertion;
static assertionForSignIn(enrollmentId: string, oneTimePassword: string): TotpMultiFactorAssertion;
static FACTOR_ID: "totp";
static FACTOR_ID: 'totp';
static generateSecret(session: MultiFactorSession): Promise<TotpSecret>;
}

Expand Down