Skip to content

Install latest chrome version for "Test Auth on Chrome and Node If Changed" test #7197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

NhienLam
Copy link
Contributor

@NhienLam NhienLam commented Apr 5, 2023

Chrome stable version 112 was released.
Revert github.com/firebase/firebase-js-sdk/pull/7157 to unpin and install the latest Chrome version for "Test Auth on Chrome and Node If Changed test."

Make sure the tests pass with the latest Chrome version.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

⚠️ No Changeset found

Latest commit: dbfe474

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@NhienLam NhienLam requested a review from prameshj April 5, 2023 16:44
@NhienLam
Copy link
Contributor Author

NhienLam commented Apr 5, 2023

"Test Auth on Chrome and Node If Changed" is using chrome version 111.0.5563.110-1 (not the newly released 112), but the test passed so I think it's fine to unpin the chrome version.

@NhienLam NhienLam changed the title Install latest chrome version Install latest chrome version for "Test Auth on Chrome and Node If Changed" test Apr 5, 2023
Copy link
Contributor

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the "test all packages" CI still fails, but fine to merge this. Thanks!

@NhienLam NhienLam merged commit 852ded6 into master Apr 5, 2023
@NhienLam NhienLam deleted the nhienlam-webdriver branch April 5, 2023 19:47
NhienLam added a commit that referenced this pull request Apr 6, 2023
prameshj added a commit that referenced this pull request Apr 6, 2023
@firebase firebase locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants