-
Notifications
You must be signed in to change notification settings - Fork 929
Install latest chrome version for "Test Auth on Chrome and Node If Changed" test #7197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (4df0099) and merge commit (6899591).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (4df0099) and merge commit (6899591).Test Logs |
"Test Auth on Chrome and Node If Changed" is using chrome version 111.0.5563.110-1 (not the newly released 112), but the test passed so I think it's fine to unpin the chrome version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the "test all packages" CI still fails, but fine to merge this. Thanks!
Chrome stable version 112 was released.
Revert github.com/firebase/firebase-js-sdk/pull/7157 to unpin and install the latest Chrome version for "Test Auth on Chrome and Node If Changed test."
Make sure the tests pass with the latest Chrome version.