Skip to content

Ensure e2e tests fail on TS errors #7184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2023
Merged

Ensure e2e tests fail on TS errors #7184

merged 2 commits into from
Apr 6, 2023

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Mar 31, 2023 •
edited
Loading

Use noEmitOnError TS config flag to ensure karma E2E tests fail if TS has a compile error.

Also getting a warning about actions/setup-node@v2 being deprecated - we should update this in all workflows.

Otherwise TS failures like the one in this E2E job are non-blocking and the workflow is considered passing https://github.com/firebase/firebase-js-sdk/actions/runs/4550223341

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a57f435

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review March 31, 2023 20:01
@hsubox76 hsubox76 requested a review from dwyfrequency as a code owner March 31, 2023 20:01
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (965396d) and merge commit (077e73c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4Eokn183M9.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 31, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (965396d) and merge commit (077e73c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VzLehOmi4e.html

dwyfrequency
dwyfrequency reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dwyfrequency
dwyfrequency approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit f1b1c5a into master Apr 6, 2023
@hsubox76 hsubox76 deleted the ch-e2e-ts branch April 6, 2023 19:32
NhienLam pushed a commit that referenced this pull request Apr 6, 2023
@hsubox76 @NhienLam
Ensure e2e tests fail on TS errors (#7184)
7d227b2
@firebase firebase locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @dwyfrequency