Skip to content

fixing error code for missing password #7171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Conversation

bhparijat
Copy link
Contributor

@bhparijat bhparijat commented Mar 29, 2023

PR to fix error code for missing password. Added a unit test case as well.

Performed manual testing with the demo app.

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

⚠️ No Changeset found

Latest commit: 3d48488

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 30, 2023

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (81cb20a)Merge (541dc55)Diff
    browser160 kB160 kB+63 B (+0.0%)
    cordova184 kB185 kB+65 B (+0.0%)
    esm5210 kB210 kB+65 B (+0.0%)
    main154 kB154 kB+65 B (+0.0%)
    module160 kB160 kB+63 B (+0.0%)
    react-native170 kB170 kB+65 B (+0.0%)
  • @firebase/auth/cordova

    TypeBase (81cb20a)Merge (541dc55)Diff
    browser184 kB185 kB+65 B (+0.0%)
    module184 kB185 kB+65 B (+0.0%)
  • @firebase/auth/internal

    TypeBase (81cb20a)Merge (541dc55)Diff
    browser171 kB171 kB+63 B (+0.0%)
    esm5223 kB223 kB+65 B (+0.0%)
    main190 kB190 kB+65 B (+0.0%)
    module171 kB171 kB+63 B (+0.0%)
  • @firebase/auth/react-native

    TypeBase (81cb20a)Merge (541dc55)Diff
    browser170 kB170 kB+65 B (+0.0%)
    module170 kB170 kB+65 B (+0.0%)
  • bundle

    TypeBase (81cb20a)Merge (541dc55)Diff
    auth (Anonymous)67.6 kB67.6 kB+2 B (+0.0%)
    auth (EmailAndPassword)71.7 kB71.7 kB+2 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)94.0 kB94.0 kB+2 B (+0.0%)
    auth (GooglePopup)91.3 kB91.3 kB+2 B (+0.0%)
    auth (GoogleRedirect)91.5 kB91.5 kB+2 B (+0.0%)
    auth (Phone)77.7 kB77.7 kB+2 B (+0.0%)
  • firebase

    TypeBase (81cb20a)Merge (541dc55)Diff
    firebase-auth-compat.js126 kB126 kB+61 B (+0.0%)
    firebase-auth-cordova.js138 kB138 kB+64 B (+0.0%)
    firebase-auth-react-native.js150 kB150 kB+64 B (+0.0%)
    firebase-auth.js120 kB120 kB+61 B (+0.1%)
    firebase-compat.js751 kB751 kB+61 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HSeSpaqIR9.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 30, 2023

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.7 kB31.7 kB+2 B (+0.0%)
      size-with-ext-deps52.4 kB52.4 kB+2 B (+0.0%)
    • ActionCodeURL

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.5 kB32.5 kB+2 B (+0.0%)
      size-with-ext-deps53.5 kB53.5 kB+2 B (+0.0%)
    • AuthCredential

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.7 kB31.7 kB+2 B (+0.0%)
      size-with-ext-deps52.4 kB52.4 kB+2 B (+0.0%)
    • AuthErrorCodes

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.1 kB36.1 kB+2 B (+0.0%)
      size-with-ext-deps56.8 kB56.8 kB+2 B (+0.0%)
    • EmailAuthCredential

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size33.6 kB33.6 kB+2 B (+0.0%)
      size-with-ext-deps54.3 kB54.3 kB+2 B (+0.0%)
    • EmailAuthProvider

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size35.1 kB35.1 kB+2 B (+0.0%)
      size-with-ext-deps56.0 kB56.0 kB+2 B (+0.0%)
    • FacebookAuthProvider

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.6 kB36.6 kB+2 B (+0.0%)
      size-with-ext-deps57.4 kB57.4 kB+2 B (+0.0%)
    • FactorId

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • GithubAuthProvider

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.6 kB36.6 kB+2 B (+0.0%)
      size-with-ext-deps57.4 kB57.4 kB+2 B (+0.0%)
    • GoogleAuthProvider

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.6 kB36.6 kB+2 B (+0.0%)
      size-with-ext-deps57.4 kB57.4 kB+2 B (+0.0%)
    • OAuthCredential

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size33.7 kB33.7 kB+2 B (+0.0%)
      size-with-ext-deps54.5 kB54.5 kB+2 B (+0.0%)
    • OAuthProvider

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size37.6 kB37.6 kB+2 B (+0.0%)
      size-with-ext-deps58.3 kB58.3 kB+2 B (+0.0%)
    • OperationType

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • PhoneAuthCredential

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size33.7 kB33.7 kB+2 B (+0.0%)
      size-with-ext-deps54.4 kB54.4 kB+2 B (+0.0%)
    • PhoneAuthProvider

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size35.4 kB35.4 kB+2 B (+0.0%)
      size-with-ext-deps56.1 kB56.1 kB+2 B (+0.0%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.4 kB32.4 kB+2 B (+0.0%)
      size-with-ext-deps53.2 kB53.2 kB+2 B (+0.0%)
    • ProviderId

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.6 kB31.6 kB+2 B (+0.0%)
      size-with-ext-deps52.3 kB52.3 kB+2 B (+0.0%)
    • RecaptchaVerifier

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size38.0 kB38.0 kB+2 B (+0.0%)
      size-with-ext-deps58.7 kB58.7 kB+2 B (+0.0%)
    • SAMLAuthProvider

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size37.9 kB37.9 kB+2 B (+0.0%)
      size-with-ext-deps58.6 kB58.6 kB+2 B (+0.0%)
    • SignInMethod

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.6 kB31.6 kB+2 B (+0.0%)
      size-with-ext-deps52.3 kB52.3 kB+2 B (+0.0%)
    • TotpMultiFactorGenerator

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size34.0 kB34.0 kB+2 B (+0.0%)
      size-with-ext-deps54.8 kB54.8 kB+2 B (+0.0%)
    • TotpSecret

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.4 kB32.4 kB+2 B (+0.0%)
      size-with-ext-deps53.1 kB53.1 kB+2 B (+0.0%)
    • TwitterAuthProvider

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.6 kB36.6 kB+2 B (+0.0%)
      size-with-ext-deps57.4 kB57.4 kB+2 B (+0.0%)
    • applyActionCode

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.7 kB31.7 kB+2 B (+0.0%)
      size-with-ext-deps52.4 kB52.4 kB+2 B (+0.0%)
    • beforeAuthStateChanged

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • browserLocalPersistence

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size34.9 kB34.9 kB+2 B (+0.0%)
      size-with-ext-deps55.7 kB55.7 kB+2 B (+0.0%)
    • browserPopupRedirectResolver

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size55.9 kB55.9 kB+2 B (+0.0%)
      size-with-ext-deps76.8 kB76.8 kB+2 B (+0.0%)
    • browserSessionPersistence

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size34.9 kB34.9 kB+2 B (+0.0%)
      size-with-ext-deps55.7 kB55.7 kB+2 B (+0.0%)
    • checkActionCode

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.8 kB32.8 kB+2 B (+0.0%)
      size-with-ext-deps53.5 kB53.5 kB+2 B (+0.0%)
    • confirmPasswordReset

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.7 kB31.7 kB+2 B (+0.0%)
      size-with-ext-deps52.4 kB52.4 kB+2 B (+0.0%)
    • connectAuthEmulator

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size33.2 kB33.2 kB+2 B (+0.0%)
      size-with-ext-deps53.9 kB53.9 kB+2 B (+0.0%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.6 kB32.6 kB+2 B (+0.0%)
      size-with-ext-deps53.3 kB53.3 kB+2 B (+0.0%)
    • debugErrorMap

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size42.6 kB42.7 kB+63 B (+0.1%)
      size-with-ext-deps63.3 kB63.4 kB+63 B (+0.1%)
    • deleteUser

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.9 kB31.9 kB+2 B (+0.0%)
      size-with-ext-deps52.6 kB52.6 kB+2 B (+0.0%)
    • getAdditionalUserInfo

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.8 kB32.8 kB+2 B (+0.0%)
      size-with-ext-deps53.5 kB53.5 kB+2 B (+0.0%)
    • getAuth

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size65.9 kB65.9 kB+2 B (+0.0%)
      size-with-ext-deps93.3 kB93.4 kB+2 B (+0.0%)
    • getIdToken

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • getIdTokenResult

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • getMultiFactorResolver

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size34.4 kB34.4 kB+2 B (+0.0%)
      size-with-ext-deps55.1 kB55.1 kB+2 B (+0.0%)
    • getRedirectResult

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size39.1 kB39.1 kB+2 B (+0.0%)
      size-with-ext-deps59.9 kB59.9 kB+2 B (+0.0%)
    • inMemoryPersistence

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • indexedDBLocalPersistence

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size38.9 kB38.9 kB+2 B (+0.0%)
      size-with-ext-deps59.6 kB59.6 kB+2 B (+0.0%)
    • initializeAuth

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.7 kB31.7 kB+2 B (+0.0%)
      size-with-ext-deps52.9 kB52.9 kB+2 B (+0.0%)
    • isSignInWithEmailLink

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.7 kB32.7 kB+2 B (+0.0%)
      size-with-ext-deps53.6 kB53.6 kB+2 B (+0.0%)
    • linkWithCredential

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.5 kB32.5 kB+2 B (+0.0%)
      size-with-ext-deps53.2 kB53.2 kB+2 B (+0.0%)
    • linkWithPhoneNumber

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.2 kB36.2 kB+2 B (+0.0%)
      size-with-ext-deps56.9 kB56.9 kB+2 B (+0.0%)
    • linkWithPopup

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size42.7 kB42.7 kB+2 B (+0.0%)
      size-with-ext-deps63.4 kB63.4 kB+2 B (+0.0%)
    • linkWithRedirect

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size37.9 kB37.9 kB+2 B (+0.0%)
      size-with-ext-deps58.7 kB58.7 kB+2 B (+0.0%)
    • multiFactor

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size33.8 kB33.8 kB+2 B (+0.0%)
      size-with-ext-deps54.5 kB54.5 kB+2 B (+0.0%)
    • onAuthStateChanged

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • onIdTokenChanged

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • parseActionCodeURL

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.6 kB32.6 kB+2 B (+0.0%)
      size-with-ext-deps53.5 kB53.5 kB+2 B (+0.0%)
    • prodErrorMap

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • reauthenticateWithCredential

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size33.1 kB33.1 kB+2 B (+0.0%)
      size-with-ext-deps53.8 kB53.8 kB+2 B (+0.0%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.7 kB36.7 kB+2 B (+0.0%)
      size-with-ext-deps57.4 kB57.5 kB+2 B (+0.0%)
    • reauthenticateWithPopup

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size42.7 kB42.7 kB+2 B (+0.0%)
      size-with-ext-deps63.4 kB63.4 kB+2 B (+0.0%)
    • reauthenticateWithRedirect

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size37.7 kB37.7 kB+2 B (+0.0%)
      size-with-ext-deps58.4 kB58.4 kB+2 B (+0.0%)
    • reload

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.4 kB31.4 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • sendEmailVerification

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.5 kB32.5 kB+2 B (+0.0%)
      size-with-ext-deps53.2 kB53.2 kB+2 B (+0.0%)
    • sendPasswordResetEmail

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.4 kB32.4 kB+2 B (+0.0%)
      size-with-ext-deps53.1 kB53.1 kB+2 B (+0.0%)
    • sendSignInLinkToEmail

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.5 kB32.5 kB+2 B (+0.0%)
      size-with-ext-deps53.2 kB53.2 kB+2 B (+0.0%)
    • setPersistence

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • signInAnonymously

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.7 kB32.7 kB+2 B (+0.0%)
      size-with-ext-deps53.5 kB53.5 kB+2 B (+0.0%)
    • signInWithCredential

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.8 kB32.9 kB+2 B (+0.0%)
      size-with-ext-deps53.6 kB53.6 kB+2 B (+0.0%)
    • signInWithCustomToken

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.6 kB32.6 kB+2 B (+0.0%)
      size-with-ext-deps53.3 kB53.3 kB+2 B (+0.0%)
    • signInWithEmailAndPassword

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.5 kB36.5 kB+2 B (+0.0%)
      size-with-ext-deps57.5 kB57.5 kB+2 B (+0.0%)
    • signInWithEmailLink

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.7 kB36.7 kB+2 B (+0.0%)
      size-with-ext-deps57.7 kB57.7 kB+2 B (+0.0%)
    • signInWithPhoneNumber

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size36.5 kB36.5 kB+2 B (+0.0%)
      size-with-ext-deps57.2 kB57.2 kB+2 B (+0.0%)
    • signInWithPopup

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size42.7 kB42.7 kB+2 B (+0.0%)
      size-with-ext-deps63.4 kB63.4 kB+2 B (+0.0%)
    • signInWithRedirect

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size37.4 kB37.4 kB+2 B (+0.0%)
      size-with-ext-deps58.1 kB58.1 kB+2 B (+0.0%)
    • signOut

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • unlink

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.1 kB32.1 kB+2 B (+0.0%)
      size-with-ext-deps52.8 kB52.8 kB+2 B (+0.0%)
    • updateCurrentUser

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • updateEmail

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.8 kB31.8 kB+2 B (+0.0%)
      size-with-ext-deps52.5 kB52.5 kB+2 B (+0.0%)
    • updatePassword

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.8 kB31.8 kB+2 B (+0.0%)
      size-with-ext-deps52.5 kB52.5 kB+2 B (+0.0%)
    • updatePhoneNumber

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.2 kB32.2 kB+2 B (+0.0%)
      size-with-ext-deps52.9 kB52.9 kB+2 B (+0.0%)
    • updateProfile

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.0 kB32.0 kB+2 B (+0.0%)
      size-with-ext-deps52.7 kB52.7 kB+2 B (+0.0%)
    • useDeviceLanguage

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size31.5 kB31.5 kB+2 B (+0.0%)
      size-with-ext-deps52.2 kB52.2 kB+2 B (+0.0%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.5 kB32.5 kB+2 B (+0.0%)
      size-with-ext-deps53.3 kB53.3 kB+2 B (+0.0%)
    • verifyPasswordResetCode

      Size

      TypeBase (81cb20a)Merge (541dc55)Diff
      size32.9 kB32.9 kB+2 B (+0.0%)
      size-with-ext-deps53.6 kB53.6 kB+2 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xIohiyiJkB.html

Copy link
Contributor

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify with the demo app as well.

@prameshj prameshj merged commit f8a2c58 into master Mar 30, 2023
@prameshj prameshj deleted the fix-empty-password-error branch March 30, 2023 21:48
dwyfrequency pushed a commit that referenced this pull request Apr 13, 2023
* fixing error code for missing password

* fixed formatting errors
@firebase firebase locked and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants