Disable httpHeadersOverwriteParam for ReactNative to address #703. #717
Conversation
packages/firestore/src/util/misc.ts
Outdated
| /** | ||
| * Detects whether we are running in a React Native app. | ||
| */ | ||
| export function isReactNative(): boolean { |
There was a problem hiding this comment.
Could we put this in a platform-detection module?
Maybe even combined with our browser version detection stuff?
There was a problem hiding this comment.
So looking to see what platform detection code already existed I discovered that, uh, this exact function already exists as a Firebase-wide helper in
. So I've opted to use it.I didn't clean up our other browser-detection code, but I added a TODO (cc/ @schmidt-sebastian since the multi-tab work is changing / adding additional browser detection logic I believe).
| // preflight round-trip. This is formally defined here: | ||
| // https://github.com/google/closure-library/blob/b0e1815b13fb92a46d7c9b3c30de5d6a396a3245/closure/goog/net/rpc/httpcors.js#L40 | ||
| // | ||
| // For some unclear reason (see |
There was a problem hiding this comment.
At a high level I understand what this comment is saying but I don't understand mechanically how this is actually working.
When we specify httpHeadersOverwriteParam: '$httpHeaders', which headers are getting tucked into that variable? If we omit setting that, where do they get set instead?
There was a problem hiding this comment.
Expanded to hopefully be clearer. Thanks for flagging.
| // preflight round-trip. This is formally defined here: | ||
| // https://github.com/google/closure-library/blob/b0e1815b13fb92a46d7c9b3c30de5d6a396a3245/closure/goog/net/rpc/httpcors.js#L40 | ||
| // | ||
| // For some unclear reason (see |
There was a problem hiding this comment.
Expanded to hopefully be clearer. Thanks for flagging.
packages/firestore/src/util/misc.ts
Outdated
| /** | ||
| * Detects whether we are running in a React Native app. | ||
| */ | ||
| export function isReactNative(): boolean { |
There was a problem hiding this comment.
So looking to see what platform detection code already existed I discovered that, uh, this exact function already exists as a Firebase-wide helper in
. So I've opted to use it.I didn't clean up our other browser-detection code, but I added a TODO (cc/ @schmidt-sebastian since the multi-tab work is changing / adding additional browser detection logic I believe).
No description provided.