Skip to content

Flag doc changes during staging release #7168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Conversation

hsubox76
Copy link
Contributor

Runs a diff against origin/master on the docs-devsite dir during the staging workflow. If a diff is found, it will send a docs_needed=true param to the release tracker. I'll make separate changes to the release tracker to then put "docs needed" in the reference CL field and highlight it red.

Need to test this, so will wait until after this week's release is done, to not interfere with it.

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

⚠️ No Changeset found

Latest commit: 7228b0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 marked this pull request as ready for review April 6, 2023 19:31
@hsubox76 hsubox76 requested a review from dwyfrequency as a code owner April 6, 2023 19:31
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 6f05b1a into master Apr 11, 2023
@hsubox76 hsubox76 deleted the ch-flag-doc-changes branch April 11, 2023 20:58
@firebase firebase locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants