Skip to content

Firestore: query.test.ts: add a test that resumes a query with existence filter #7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Mar 17, 2023

This PR was ported to the Android SDK in firebase/firebase-android-sdk#4799 and to the iOS SDK in firebase/firebase-ios-sdk#10974.

@dconeybe dconeybe self-assigned this Mar 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

⚠️ No Changeset found

Latest commit: eced062

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 17, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 17, 2023

@dconeybe dconeybe changed the title Firestore: query.test.ts: add a test for resuming a query with existence filter Firestore: query.test.ts: add a test that resumes a query with existence filter Mar 18, 2023
@dconeybe dconeybe requested a review from milaGGL March 18, 2023 20:24
@dconeybe dconeybe merged commit 04b3edb into master Mar 20, 2023
@dconeybe dconeybe deleted the dconeybe/QueryExistenceFilterTest branch March 20, 2023 22:39
renkelvin pushed a commit that referenced this pull request Mar 21, 2023
dconeybe added a commit that referenced this pull request Mar 23, 2023
…existence filter to actually validate the existence filter.

This builds upon the test added in #7134
dconeybe added a commit that referenced this pull request Mar 23, 2023
…existence filter to actually validate the existence filter.

This builds upon the test added in #7134
dconeybe added a commit that referenced this pull request Mar 23, 2023
…existence filter to actually validate the existence filter.

This builds upon the test added in #7134
dconeybe added a commit that referenced this pull request Mar 23, 2023
…existence filter to actually validate the existence filter.

This builds upon the test added in #7134
@firebase firebase locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants