Skip to content

Adding a TODO in notifyLocalViewChanges #7103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

Adding a TODO in notifyLocalViewChanges #7103

merged 1 commit into from
Mar 15, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Mar 8, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 47bf854

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 8, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (2e22d5b) and merge commit (0169731).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EffEfAHIM2.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 8, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (2e22d5b) and merge commit (0169731).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OSMkFY1j8t.html

@wu-hui wu-hui force-pushed the wuandy/RefactorShouldPersist branch from f69eb7e to 0b8925c Compare March 8, 2023 16:09
@wu-hui wu-hui force-pushed the wuandy/RefactorShouldPersist branch from 0b8925c to 47bf854 Compare March 9, 2023 21:15
@wu-hui wu-hui requested a review from MarkDuckworth March 13, 2023 18:43
@wu-hui wu-hui changed the title Refactor notifyLocalViewChanges Adding a TODO in notifyLocalViewChanges Mar 13, 2023
MarkDuckworth
MarkDuckworth approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-hui wu-hui merged commit a8be6ed into master Mar 15, 2023
@wu-hui wu-hui deleted the wuandy/RefactorShouldPersist branch March 15, 2023 17:27
renkelvin pushed a commit that referenced this pull request Mar 21, 2023
@wu-hui
Add a TODO (#7103)
930ca10
dwyfrequency pushed a commit that referenced this pull request Mar 23, 2023
@wu-hui @dwyfrequency
Add a TODO (#7103)
715ee9b
@firebase firebase locked and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @MarkDuckworth