Skip to content

remove startMfaSignIn step for TOTP, since it requires only one step. #7047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

remove startMfaSignIn step for TOTP, since it requires only one step. #7047

merged 1 commit into from
Feb 22, 2023

Conversation

prameshj
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 188c2cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 18, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (57c32b9) and merge commit (f17e779).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mlgSgW6tpM.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 18, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (57c32b9) and merge commit (f17e779).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YGvEWBvMiB.html

@prameshj
remove startMfaSignIn step for TOTP.
188c2cd 
TOTP only needs a finalize step.
@prameshj
Copy link
Contributor Author

Verified with the demo app that the TOTP enroll + login flow works.

@prameshj prameshj merged commit 847b228 into mfa-totp Feb 22, 2023
@prameshj prameshj deleted the mfa-totp-prameshj branch February 22, 2023 22:20
prameshj added a commit that referenced this pull request Mar 20, 2023
@prameshj
remove startMfaSignIn step for TOTP. (#7047)
522392a 
TOTP only needs a finalize step.
@firebase firebase locked and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prameshj @google-oss-bot