Skip to content

Tests for sum and average. #7000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 8, 2023

Conversation

MarkDuckworth
Copy link
Contributor

Tests for sum and average, plus a few fixes.

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023

⚠️ No Changeset found

Latest commit: e6a5c16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2023

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (7e4521a)Merge (5544929)Diff
    browser273 kB274 kB+583 B (+0.2%)
    esm5340 kB341 kB+618 B (+0.2%)
    main547 kB548 kB+872 B (+0.2%)
    module273 kB274 kB+583 B (+0.2%)
    react-native273 kB274 kB+583 B (+0.2%)
  • @firebase/firestore-lite

    TypeBase (7e4521a)Merge (5544929)Diff
    browser86.8 kB87.4 kB+583 B (+0.7%)
    esm5105 kB105 kB+618 B (+0.6%)
    main148 kB149 kB+872 B (+0.6%)
    module86.8 kB87.4 kB+583 B (+0.7%)
    react-native87.0 kB87.6 kB+583 B (+0.7%)
  • bundle

    TypeBase (7e4521a)Merge (5544929)Diff
    firestore-lite (Transaction)84.0 kB84.0 kB+2 B (+0.0%)
  • firebase

    TypeBase (7e4521a)Merge (5544929)Diff
    firebase-firestore-lite.js93.5 kB94.0 kB+583 B (+0.6%)
    firebase-firestore.js322 kB323 kB+583 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/p5zioxmh0M.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2023

Size Analysis Report 1

This report is too large (712,929 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4z23wiA96j.html

Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the thorough test coverage. Maybe we should consider whether it's necessary to allow special characters and whether TrimBackticks is needed?

@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas Feb 3, 2023
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas removed their assignment Feb 8, 2023
@MarkDuckworth MarkDuckworth merged commit 1db5944 into markduckworth/sum-avg Feb 8, 2023
@MarkDuckworth MarkDuckworth deleted the markduckworth/sum-avg-tests branch February 8, 2023 21:32
@firebase firebase locked and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants