Skip to content

fix(app): Allow Object.prototype member names as app names #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2017
Merged

fix(app): Allow Object.prototype member names as app names #70

merged 1 commit into from
Jun 20, 2017

Conversation

jsayol
Copy link
Contributor

@jsayol jsayol commented Jun 19, 2017

Discussion

Fix for issue #69

This implements the option 1 approach mentioned in the linked issue.

Note: Once the ts-database/add-new-impl branch has been merged into master, the contains function definition should be replaced with an import from src/utils/obj.ts

Testing

Added 2 tests

API Changes

None.

@jshcrowthe
Copy link
Contributor

FWIW: we can probably leave the logic for this alone if we use the safeGet function from the same file. But it's a trivial change.

jshcrowthe
jshcrowthe approved these changes Jun 20, 2017
View reviewed changes
Copy link
Contributor

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jshcrowthe jshcrowthe merged commit 109cbb3 into firebase:master Jun 20, 2017
@jsayol jsayol deleted the fix-app-name branch June 20, 2017 16:56
@jsayol
Copy link
Contributor Author

jsayol commented Jun 20, 2017

Good point, I'll keep that in mind!

@renovate-tests renovate-tests mentioned this pull request Jul 7, 2017
Open
@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jshcrowthe jshcrowthe jshcrowthe approved these changes

Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsayol @jshcrowthe @google-oss-bot