Skip to content

Refactor Firestore tests to use targetBackend parameter #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 8, 2023
Merged

Refactor Firestore tests to use targetBackend parameter #6999

merged 14 commits into from
Feb 8, 2023

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Feb 2, 2023 •
edited
Loading

Make targeting different backends easy

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 23da5c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (70c042a) and merge commit (b774ca4).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jGcud2KWOJ.html

@tom-andersen tom-andersen changed the title Refactor Firestore target backend parameters to simplify and better s… Refactor Firestore tests to use targetBackend parameter Feb 2, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (70c042a) and merge commit (b774ca4).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yfs3v8h97q.html

@tom-andersen tom-andersen marked this pull request as ready for review February 6, 2023 15:10
@tom-andersen tom-andersen requested a review from ehsannas February 6, 2023 16:18
ehsannas
ehsannas reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@ehsannas ehsannas assigned tom-andersen and unassigned ehsannas Feb 8, 2023
@tom-andersen tom-andersen assigned ehsannas and unassigned ehsannas and tom-andersen Feb 8, 2023
@ehsannas ehsannas assigned tom-andersen and unassigned ehsannas Feb 8, 2023
@tom-andersen tom-andersen merged commit fa0a7c0 into master Feb 8, 2023
@tom-andersen tom-andersen deleted the tomandersen/testImprovement branch February 8, 2023 21:32
hsubox76 pushed a commit that referenced this pull request Feb 9, 2023
@tom-andersen @hsubox76
Refactor Firestore tests to use targetBackend parameter (#6999)
e7fb2c7 
* Refactor Firestore target backend parameters to simplify and better support preprod

* Undo `only` in test

* Formatting

* Fix

* Replace local with targetBackend=emulator

* Fix

* Run directly from ts file to avoid compiler problems.

* Remove unused dependency

* Remove unused dependency

* Remove unused dependency

* Fix test when running on emulator

* Override linter

* Add comments
@firebase firebase locked and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

Assignees

@hsubox76 hsubox76

@tom-andersen tom-andersen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tom-andersen @google-oss-bot @ehsannas @hsubox76