Skip to content

Add a command to run totp integration tests as part of the CI #6998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

prameshj
Copy link
Contributor

@prameshj prameshj commented Feb 2, 2023

These tests will run against the real backend, since we do not have emulator support yet.

Running yarn test:browser:integration:prodbackend passed against my own project.

Run against the jscore-sandbox-141b51 passed as well - https://github.com/firebase/firebase-js-sdk/actions/runs/4075626218/jobs/7219953819

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023

⚠️ No Changeset found

Latest commit: 1f51d45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 2, 2023

@prameshj prameshj merged commit 57c32b9 into mfa-totp Feb 15, 2023
@prameshj prameshj deleted the mfa-totp-integrationtest branch February 15, 2023 00:11
@firebase firebase locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants