Skip to content

Fix link format in auth doc comment #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix link format in auth doc comment #6980

merged 1 commit into from
Jan 26, 2023

Conversation

hsubox76
Copy link
Contributor

Need to use @link tag for links in comments, not markdown. Markdown will get escaped by api-documenter and not work in devsite.

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023

⚠️ No Changeset found

Latest commit: 0c879ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review January 25, 2023 20:04
@hsubox76 hsubox76 requested a review from prameshj January 25, 2023 20:04
prameshj
prameshj approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (6836974) and merge commit (76ac8fc).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iG5rdfrTCo.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (6836974) and merge commit (76ac8fc).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sLQIozTElZ.html

@hsubox76 hsubox76 merged commit f8ddadb into master Jan 26, 2023
@hsubox76 hsubox76 deleted the ch-fix-auth-link branch January 26, 2023 18:29
@firebase firebase locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@prameshj prameshj prameshj approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @google-oss-bot @sam-gc @prameshj