Skip to content

Remove innerHTML call and replace with textContent #6916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 10, 2023
Merged

Remove innerHTML call and replace with textContent #6916

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe37ed8
Remove innerHTML call
dwyfrequency Dec 29, 2022
974e32a
Update to innerText
dwyfrequency Dec 29, 2022
2d416eb
Update comment to say innerText
dwyfrequency Dec 29, 2022
03e6366
replace innerText with textContent
dwyfrequency Dec 29, 2022
73cb0e3
Updating comment to textContent
dwyfrequency Dec 29, 2022
2395048
Add changeset
dwyfrequency Dec 29, 2022
10acf1c
Reword changeset
dwyfrequency Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/database/src/realtime/BrowserPollConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,8 @@ export class FirebaseIFrameScriptHolder {
if (this.myIFrame) {
//We have to actually remove all of the html inside this iframe before removing it from the
//window, or IE will continue loading and executing the script tags we've already added, which
//can lead to some errors being thrown. Setting innerHTML seems to be the easiest way to do this.
this.myIFrame.doc.body.innerHTML = '';
//can lead to some errors being thrown. Setting innerText seems to be the safest way to do this.
this.myIFrame.doc.body.textContent = '';
setTimeout(() => {
if (this.myIFrame !== null) {
document.body.removeChild(this.myIFrame);
Expand Down