Skip to content

Fix mfa totp unit test #6858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2022
Merged

Fix mfa totp unit test #6858

merged 2 commits into from
Dec 7, 2022

Conversation

prameshj
Copy link
Contributor

@prameshj prameshj commented Dec 6, 2022 •
edited
Loading

Also removed the totp-generator.d.ts file and used the ts-ignore annotation instead.

The previous approach was causing CI test failures.

cc @hsubox76 @bhparijat

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9660645

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 6, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (78b3d41) and merge commit (2f40cd9).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yKburcB3vH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 6, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (78b3d41) and merge commit (2f40cd9).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/U8Vrhu49dg.html

@prameshj prameshj marked this pull request as ready for review December 7, 2022 01:41
@prameshj prameshj merged commit 2857f04 into mfa-totp Dec 7, 2022
@prameshj prameshj deleted the prameshj-mfa-totp branch December 7, 2022 18:43
@firebase firebase locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prameshj @google-oss-bot