Skip to content

Fixing conflict in package.json #6855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fixing conflict in package.json #6855

merged 1 commit into from
Dec 5, 2022

Conversation

bhparijat
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

⚠️ No Changeset found

Latest commit: 9685d69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bhparijat bhparijat changed the base branch from mfa-totp to master December 5, 2022 22:54
@bhparijat bhparijat changed the base branch from master to mfa-totp December 5, 2022 22:55
@prameshj prameshj merged commit 78b3d41 into mfa-totp Dec 5, 2022
@prameshj prameshj deleted the parijat-package.json-fix branch December 5, 2022 23:12
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?20.1 kB? (?)
    esm5?24.8 kB? (?)
    main?26.1 kB? (?)
    module?20.1 kB? (?)

  • @firebase/analytics-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?2.57 kB? (?)
    esm5?2.80 kB? (?)
    main?3.24 kB? (?)
    module?2.57 kB? (?)

  • @firebase/api-documenter

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    main?3.95 kB? (?)

  • @firebase/app

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?14.3 kB? (?)
    esm5?18.8 kB? (?)
    main?19.7 kB? (?)
    module?14.3 kB? (?)

  • @firebase/app-check

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?25.2 kB? (?)
    esm5?30.3 kB? (?)
    main?31.3 kB? (?)
    module?25.2 kB? (?)

  • @firebase/app-check-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?2.27 kB? (?)
    esm5?2.48 kB? (?)
    main?2.94 kB? (?)
    module?2.27 kB? (?)

  • @firebase/app-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?5.28 kB? (?)
    esm5?6.13 kB? (?)
    lite?4.06 kB? (?)
    main?6.73 kB? (?)
    module?5.28 kB? (?)

  • @firebase/auth

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?160 kB? (?)
    cordova?184 kB? (?)
    esm5?210 kB? (?)
    main?154 kB? (?)
    module?160 kB? (?)
    react-native?170 kB? (?)

  • @firebase/auth-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?20.2 kB? (?)
    esm5?27.1 kB? (?)
    main?29.6 kB? (?)
    module?20.2 kB? (?)

  • @firebase/auth/cordova

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?184 kB? (?)
    module?184 kB? (?)

  • @firebase/auth/internal

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?171 kB? (?)
    esm5?223 kB? (?)
    main?190 kB? (?)
    module?171 kB? (?)

  • @firebase/auth/react-native

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?170 kB? (?)
    module?170 kB? (?)

  • @firebase/component

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?6.54 kB? (?)
    esm5?8.70 kB? (?)
    main?9.08 kB? (?)
    module?6.54 kB? (?)

  • @firebase/database

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?247 kB? (?)
    esm5?276 kB? (?)
    main?281 kB? (?)
    module?247 kB? (?)

  • @firebase/database-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?18.0 kB? (?)
    esm5?21.1 kB? (?)
    main?21.8 kB? (?)
    module?18.0 kB? (?)

  • @firebase/database-compat/standalone

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    main?370 kB? (?)

  • @firebase/firestore

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?272 kB? (?)
    esm5?339 kB? (?)
    main?545 kB? (?)
    module?272 kB? (?)
    react-native?273 kB? (?)

  • @firebase/firestore-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?20.5 kB? (?)
    esm5?27.6 kB? (?)
    main?20.9 kB? (?)
    module?20.5 kB? (?)
    react-native?20.5 kB? (?)

  • @firebase/firestore-lite

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?86.2 kB? (?)
    esm5?104 kB? (?)
    main?147 kB? (?)
    module?86.2 kB? (?)
    react-native?86.4 kB? (?)

  • @firebase/functions

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?9.55 kB? (?)
    esm5?11.8 kB? (?)
    main?12.6 kB? (?)
    module?9.55 kB? (?)

  • @firebase/functions-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?1.79 kB? (?)
    esm5?1.98 kB? (?)
    main?2.34 kB? (?)
    module?1.79 kB? (?)

  • @firebase/installations

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?17.8 kB? (?)
    esm5?23.1 kB? (?)
    main?23.9 kB? (?)
    module?17.8 kB? (?)

  • @firebase/installations-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?945 B? (?)
    esm5?1.16 kB? (?)
    main?1.49 kB? (?)
    module?945 B? (?)

  • @firebase/logger

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    esm5?4.75 kB? (?)
    main?5.41 kB? (?)
    module?3.25 kB? (?)

  • @firebase/messaging

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?21.4 kB? (?)
    esm5?26.8 kB? (?)
    main?27.5 kB? (?)
    module?21.4 kB? (?)

  • @firebase/messaging-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?2.08 kB? (?)
    esm5?2.51 kB? (?)
    main?2.90 kB? (?)
    module?2.08 kB? (?)

  • @firebase/messaging-sw

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    main?30.2 kB? (?)
    module?23.4 kB? (?)

  • @firebase/performance

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?29.1 kB? (?)
    esm5?31.0 kB? (?)
    main?31.5 kB? (?)
    module?29.1 kB? (?)

  • @firebase/performance-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?1.10 kB? (?)
    esm5?1.38 kB? (?)
    main?1.69 kB? (?)
    module?1.10 kB? (?)

  • @firebase/remote-config

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?19.2 kB? (?)
    esm5?24.1 kB? (?)
    main?25.3 kB? (?)
    module?19.2 kB? (?)

  • @firebase/remote-config-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?1.85 kB? (?)
    esm5?2.76 kB? (?)
    main?3.09 kB? (?)
    module?1.85 kB? (?)

  • @firebase/rules-unit-testing

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    main?17.8 kB? (?)

  • @firebase/storage

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?56.0 kB? (?)
    esm5?62.5 kB? (?)
    main?58.5 kB? (?)
    module?56.0 kB? (?)

  • @firebase/storage-compat

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?5.67 kB? (?)
    esm5?8.41 kB? (?)
    main?8.82 kB? (?)
    module?5.67 kB? (?)

  • @firebase/util

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    browser?22.7 kB? (?)
    esm5?24.2 kB? (?)
    main?29.7 kB? (?)
    module?22.7 kB? (?)

  • @firebase/webchannel-wrapper

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    esm5?44.7 kB? (?)
    main?54.6 kB? (?)
    module?42.4 kB? (?)

  • bundle

    43 size changes

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    analytics (logEvent)?43.0 kB? (?)
    app-check (CustomProvider)?36.1 kB? (?)
    app-check (ReCaptchaEnterpriseProvider)?38.4 kB? (?)
    app-check (ReCaptchaV3Provider)?38.4 kB? (?)
    auth (Anonymous)?67.4 kB? (?)
    auth (EmailAndPassword)?71.5 kB? (?)
    auth (GoogleFBTwitterGitHubPopup)?93.9 kB? (?)
    auth (GooglePopup)?91.1 kB? (?)
    auth (GoogleRedirect)?91.3 kB? (?)
    auth (Phone)?77.6 kB? (?)
    database (Append to a list of data)?148 kB? (?)
    database (Filtering data)?147 kB? (?)
    database (Listen for child events)?163 kB? (?)
    database (Listen for value events + Detach listeners)?163 kB? (?)
    database (Listen for value events)?163 kB? (?)
    database (Read data once)?163 kB? (?)
    database (Save data as transactions)?165 kB? (?)
    database (Sort data)?148 kB? (?)
    database (Write data)?147 kB? (?)
    firestore (Persistence)?281 kB? (?)
    firestore (Query Cursors)?220 kB? (?)
    firestore (Query)?217 kB? (?)
    firestore (Read data once)?205 kB? (?)
    firestore (Realtime updates)?207 kB? (?)
    firestore (Transaction)?188 kB? (?)
    firestore (Write data)?188 kB? (?)
    firestore-lite (Query Cursors)?81.3 kB? (?)
    firestore-lite (Query)?77.4 kB? (?)
    firestore-lite (Read data once)?59.4 kB? (?)
    firestore-lite (Transaction)?84.0 kB? (?)
    firestore-lite (Write data)?68.9 kB? (?)
    functions (call)?30.9 kB? (?)
    messaging (send + receive)?46.4 kB? (?)
    performance (trace)?50.8 kB? (?)
    remote-config (getAndFetch)?45.4 kB? (?)
    storage (getBytes)?40.1 kB? (?)
    storage (getDownloadURL)?42.1 kB? (?)
    storage (getMetadata)?41.6 kB? (?)
    storage (list + listAll)?41.0 kB? (?)
    storage (updateMetadata)?41.8 kB? (?)
    storage (uploadBytes)?46.8 kB? (?)
    storage (uploadBytesResumable)?56.8 kB? (?)
    storage (uploadString)?47.0 kB? (?)

  • firebase

    31 size changes

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    firebase-analytics-compat.js?25.8 kB? (?)
    firebase-analytics.js?24.9 kB? (?)
    firebase-app-check-compat.js?22.6 kB? (?)
    firebase-app-check.js?21.4 kB? (?)
    firebase-app-compat.js?28.8 kB? (?)
    firebase-app.js?92.0 kB? (?)
    firebase-auth-compat.js?126 kB? (?)
    firebase-auth-cordova.js?138 kB? (?)
    firebase-auth-react-native.js?150 kB? (?)
    firebase-auth.js?120 kB? (?)
    firebase-compat.js?746 kB? (?)
    firebase-database-compat.js?165 kB? (?)
    firebase-database.js?154 kB? (?)
    firebase-firestore-compat.js?320 kB? (?)
    firebase-firestore-lite.js?92.9 kB? (?)
    firebase-firestore.js?321 kB? (?)
    firebase-functions-compat.js?8.12 kB? (?)
    firebase-functions.js?10.9 kB? (?)
    firebase-installations-compat.js?13.2 kB? (?)
    firebase-installations.js?12.5 kB? (?)
    firebase-messaging-compat.js?38.2 kB? (?)
    firebase-messaging-sw.js?26.0 kB? (?)
    firebase-messaging.js?24.8 kB? (?)
    firebase-performance-compat.js?30.8 kB? (?)
    firebase-performance-standalone-compat.es2017.js?89.9 kB? (?)
    firebase-performance-standalone-compat.js?67.0 kB? (?)
    firebase-performance.js?30.8 kB? (?)
    firebase-remote-config-compat.js?27.2 kB? (?)
    firebase-remote-config.js?26.3 kB? (?)
    firebase-storage-compat.js?39.4 kB? (?)
    firebase-storage.js?39.0 kB? (?)

  • functions

    TypeBase (9ad8b23)Merge (cb0e93a)Diff
    main?46 B? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/evTxldLN23.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

This report is too large (1,463,998 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GtdgYUfeEz.html

@firebase firebase locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhparijat @google-oss-bot @prameshj