Skip to content

Add set tenant method to demo app #6850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

bhparijat
Copy link
Contributor

Adding functionality for setting tenant in demo app in order to test TOTP MFA at tenant level

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2022

⚠️ No Changeset found

Latest commit: 5f0fdfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 3, 2022

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 3, 2022

@bhparijat bhparijat force-pushed the add-tenant-demo-app branch 3 times, most recently from 18d8a7e to 330ee4d Compare December 7, 2022 20:51
@bhparijat bhparijat force-pushed the add-tenant-demo-app branch from 330ee4d to 5f0fdfd Compare December 7, 2022 20:57
@bhparijat bhparijat requested a review from prameshj December 7, 2022 21:47
@bhparijat bhparijat merged commit 0df93b4 into mfa-totp Dec 7, 2022
@bhparijat bhparijat deleted the add-tenant-demo-app branch December 7, 2022 22:24
@firebase firebase locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants