-
Notifications
You must be signed in to change notification settings - Fork 927
6801 catch insecure indexedDB access #6841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6801 catch insecure indexedDB access #6841
Conversation
🦋 Changeset detectedLatest commit: 5aa8147 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
44212ba
to
e33d728
Compare
e33d728
to
eb27d52
Compare
I'm trying to reproduce the error you showed here #6801 (comment) I set Firefox to block all third-party cookies and I can't seem to reproduce it. When I type in "indexedDB" it says |
I think the key part here is:
So if you will open for example this page https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe , open console and type For us this is an issue because we use Firebase from inside an iframe hosted by us, but iframe is inside Jira/Azure context , so top domain is different. Looks like some companies like to have this cookie policy set on some browsers. Unfortunately Firefox throws some exception. |
Thanks! Got it. In that case the change looks good. Will merge when required checks pass. |
Oops, looks like it failed the formatting check. Can you run |
Related issue:
#6801