Skip to content

Totp integration test fix #6814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 3, 2022
Merged

Totp integration test fix #6814

merged 5 commits into from
Dec 3, 2022

Conversation

bhparijat
Copy link
Contributor

Used timestamp to get future totp codes using totp-generator

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 94410e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bhparijat bhparijat changed the base branch from master to parijat-totp-integration November 19, 2022 05:39
Base automatically changed from parijat-totp-integration to mfa-totp November 22, 2022 18:15
@bhparijat bhparijat force-pushed the parijat-totp-integration-test-fix branch 2 times, most recently from 49e2902 to 81788fd Compare November 22, 2022 23:53
@bhparijat bhparijat force-pushed the parijat-totp-integration-test-fix branch from 81788fd to 858487c Compare November 23, 2022 00:06
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 23, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (0a20bcf) and merge commit (92a70df).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/l45Bu68zpV.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 23, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (0a20bcf) and merge commit (92a70df).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yP3l7Yvvhp.html

sam-gc
sam-gc reviewed Nov 28, 2022
View reviewed changes
@bhparijat bhparijat force-pushed the parijat-totp-integration-test-fix branch from 42d7a40 to 5680ca5 Compare November 30, 2022 01:10
bhparijat
bhparijat commented Nov 30, 2022
View reviewed changes
Copy link
Contributor Author

@bhparijat bhparijat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used skipping method

@bhparijat bhparijat force-pushed the parijat-totp-integration-test-fix branch 2 times, most recently from 8dfb01a to 94410e9 Compare December 3, 2022 04:38
@bhparijat bhparijat merged commit f1e7f12 into mfa-totp Dec 3, 2022
@bhparijat bhparijat deleted the parijat-totp-integration-test-fix branch December 3, 2022 05:26
bhparijat added a commit that referenced this pull request Dec 3, 2022
@bhparijat
Totp integration test fix (#6814)
0c5c81d 
* removed delay function and used timestamp for totp generator

* updated yarn.lock to show totp-generator

* added check for signin after unenroll

* adding skippig of totp tests if emulator is being used

* using this.skip to skip tests
bhparijat added a commit that referenced this pull request Dec 3, 2022
@bhparijat
Totp integration test fix (#6814)
9ad8b23 
* removed delay function and used timestamp for totp generator

* updated yarn.lock to show totp-generator

* added check for signin after unenroll

* adding skippig of totp tests if emulator is being used

* using this.skip to skip tests
@firebase firebase locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prameshj prameshj prameshj approved these changes

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bhparijat @google-oss-bot @sam-gc @prameshj