Fixed event comparison issue in Syncpointspec tests #6786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 888a98d The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check
|
Size Report 1Affected ProductsNo changes between base commit (e9fb403) and merge commit (50d7ca9).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (e9fb403) and merge commit (a87034e).Test Logs |
jmwski
reviewed
Nov 14, 2022
Comment on lines
232
to
238
| const EVENT_ORDERING = [ | ||
| 'child_removed', | ||
| 'child_added', | ||
| 'child_moved', | ||
| 'child_changed', | ||
| 'value' | ||
| ]; |
There was a problem hiding this comment.
@puf It seems that at one point we were enforcing this order. Just FYI.
jmwski
approved these changes
Nov 14, 2022
egilmorez
approved these changes
Nov 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem where comparisons between expected and actual events weren't happening correctly.
Fixing this caused other tests to fail because we expected specific events to be raised before other events. However, this is not how the SDKs work now. They order events based on where the event is in the synctree, not based on type of the event.