Skip to content

integration tests for totp #6784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 22, 2022
Merged

integration tests for totp #6784

merged 6 commits into from
Nov 22, 2022

Conversation

bhparijat
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3f9736f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bhparijat bhparijat changed the base branch from master to mfa-totp November 12, 2022 00:13
@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 12, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (d8c26f6) and merge commit (66a1e99).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/naRvsmF9es.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 12, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (d8c26f6) and merge commit (66a1e99).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VTO1I3Fnkj.html

@github-actions github-actions bot added the doc-changes PRs that affect docs label Nov 12, 2022
@prameshj prameshj marked this pull request as draft November 14, 2022 03:58
prameshj
prameshj reviewed Nov 14, 2022
View reviewed changes
Copy link
Contributor

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@bhparijat bhparijat force-pushed the parijat-totp-integration branch from ed7c49b to 5945b5c Compare November 18, 2022 06:40
@bhparijat bhparijat requested a review from prameshj November 18, 2022 06:41
@bhparijat bhparijat force-pushed the parijat-totp-integration branch 2 times, most recently from b07194d to 2a12a01 Compare November 18, 2022 07:14
@bhparijat bhparijat force-pushed the parijat-totp-integration branch 2 times, most recently from e13f83e to 33cf0da Compare November 18, 2022 22:25
@bhparijat bhparijat force-pushed the parijat-totp-integration branch from 33cf0da to c56b85d Compare November 18, 2022 22:29
@bhparijat bhparijat requested review from sam-gc and prameshj November 18, 2022 22:38
@bhparijat bhparijat marked this pull request as ready for review November 18, 2022 22:48
prameshj
prameshj reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 small nits, lgtm otherwise. thanks for adding this!

@bhparijat bhparijat requested a review from prameshj November 22, 2022 07:42
@bhparijat bhparijat merged commit 0a20bcf into mfa-totp Nov 22, 2022
@bhparijat bhparijat deleted the parijat-totp-integration branch November 22, 2022 18:15
bhparijat added a commit that referenced this pull request Dec 3, 2022
@bhparijat
integration tests for totp (#6784)
7c71003 
* totp integration test

* test cases working with verified email

* removing debug logs

* changed test email and fixed handling of user delete for totp

* reverting unwanted changes in helper.ts

* modified comments
bhparijat added a commit that referenced this pull request Dec 3, 2022
@bhparijat
integration tests for totp (#6784)
cee33b9 
* totp integration test

* test cases working with verified email

* removing debug logs

* changed test email and fixed handling of user delete for totp

* reverting unwanted changes in helper.ts

* modified comments
@firebase firebase locked and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@prameshj prameshj prameshj approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@egilmorez egilmorez

Labels
doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhparijat @google-oss-bot @sam-gc @prameshj @egilmorez