Relaxing in restrictions. #6757

MarkDuckworth · 2022-11-04T23:15:56Z

relaxing in restrictions
port of Remove some query restrictions and add integration tests firebase-android-sdk#4231

Add composite filters. Port of firebase/firebase-android-sdk#3290

…arkduckworth/or-queries-pr-3

* Support encoding and decoding Composite Filters

…se-js-sdk into markduckworth/or-queries-pr-4

…kduckworth/or-queries

…-pr-4

…rve OR queries from client-side index.

…r messages.

changeset-bot · 2022-11-04T23:15:59Z

⚠️ No Changeset found

Latest commit: 1280052

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2022-11-04T23:36:39Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (fa0a7c0) Merge (3d98cc2) Diff
browser 273 kB 273 kB -86 B (-0.0%)
esm5 339 kB 339 kB -86 B (-0.0%)
main 546 kB 546 kB -86 B (-0.0%)
module 273 kB 273 kB -86 B (-0.0%)
react-native 273 kB 273 kB -86 B (-0.0%)

`@firebase/firestore-lite`

Type	Base (`fa0a7c0`)	Merge (`3d98cc2`)	Diff
browser	86.2 kB	86.1 kB	-86 B (-0.1%)
esm5	104 kB	104 kB	-86 B (-0.1%)
main	147 kB	147 kB	-86 B (-0.1%)
module	86.2 kB	86.1 kB	-86 B (-0.1%)
react-native	86.4 kB	86.3 kB	-86 B (-0.1%)

`bundle`

Type	Base (`fa0a7c0`)	Merge (`3d98cc2`)	Diff
firestore (Query Cursors)	220 kB	220 kB	-86 B (-0.0%)
firestore (Query)	218 kB	217 kB	-86 B (-0.0%)
firestore-lite (Query Cursors)	81.3 kB	81.2 kB	-86 B (-0.1%)
firestore-lite (Query)	77.4 kB	77.3 kB	-86 B (-0.1%)

`firebase`

Type	Base (`fa0a7c0`)	Merge (`3d98cc2`)	Diff
firebase-compat.js	747 kB	747 kB	-86 B (-0.0%)
firebase-firestore-compat.js	321 kB	321 kB	-86 B (-0.0%)
firebase-firestore-lite.js	92.9 kB	92.8 kB	-86 B (-0.1%)
firebase-firestore.js	321 kB	321 kB	-86 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/k3SNFavvEz.html

google-oss-bot · 2022-11-04T23:53:45Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- QueryCompositeFilterConstraint
  Size
  Type Base (fa0a7c0) Merge (3d98cc2) Diff
  size 19.8 kB 19.7 kB -86 B (-0.4%)
  size-with-ext-deps 78.6 kB 78.5 kB -86 B (-0.1%)
- QueryFieldFilterConstraint
  Size
  Type Base (fa0a7c0) Merge (3d98cc2) Diff
  size 40.8 kB 40.7 kB -86 B (-0.2%)
  size-with-ext-deps 99.7 kB 99.6 kB -86 B (-0.1%)
- and
  Size
  Type Base (fa0a7c0) Merge (3d98cc2) Diff
  size 42.3 kB 42.2 kB -86 B (-0.2%)
  size-with-ext-deps 101 kB 101 kB -86 B (-0.1%)
- or
  Size
  Type Base (fa0a7c0) Merge (3d98cc2) Diff
  size 42.3 kB 42.2 kB -86 B (-0.2%)
  size-with-ext-deps 101 kB 101 kB -86 B (-0.1%)
- query
  Size
  Type Base (fa0a7c0) Merge (3d98cc2) Diff
  size 42.5 kB 42.4 kB -86 B (-0.2%)
  size-with-ext-deps 101 kB 101 kB -86 B (-0.1%)
- where
  Size
  Type Base (fa0a7c0) Merge (3d98cc2) Diff
  size 41.6 kB 41.5 kB -86 B (-0.2%)
  size-with-ext-deps 101 kB 100 kB -86 B (-0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/sDjjBre1Gv.html

packages/firestore/test/integration/api/validation.test.ts

packages/firestore/test/integration/api/query.test.ts

…eries-relaxing-in-restrictions

ehsannas · 2022-11-11T00:33:49Z

packages/firestore/test/integration/api/validation.test.ts

-      ).to.throw(
-        "Invalid query. You cannot use more than one 'not-in' filter."
-      );
+    validationIt.only(


remove .only

…ictions

MarkDuckworth · 2023-02-09T21:19:37Z

Cherry picked to #7024.

MarkDuckworth and others added 30 commits June 24, 2022 14:53

Add composite filters. Port of firebase/firebase-android-sdk#3290

effced9

Cleanup: lint

eba3b84

Support encoding and decoding Composite Filters

33a0896

Formatting

9f6e216

Add composite filters in support of OR queries (#6385)

a722abc

Add composite filters. Port of firebase/firebase-android-sdk#3290

Merge remote-tracking branch 'origin/markduckworth/or-queries' into m…

6556240

…arkduckworth/or-queries-pr-3

Fix issue with readonly array.

78a8900

WIP: serving results from index.

80fc05d

Support encoding and decoding Composite Filters (#6402)

1e33050

* Support encoding and decoding Composite Filters

Perform DNF transform

8b6f05f

Cleanup and tests from firebase/firebase-android-sdk#3444

152fc18

Merge branch 'markduckworth/or-queries' of github.com:firebase/fireba…

8b0bfbd

…se-js-sdk into markduckworth/or-queries-pr-4

Merge branch 'master' of github.com:firebase/firebase-js-sdk into mar…

45be193

…kduckworth/or-queries

use index if we have composite filters

1c948cb

Merge branch 'markduckworth/or-queries' into markduckworth/or-queries…

2cad46c

…-pr-4

Fix bad import

266f7f6

Update the orderBy filtering mechanism for OR queries and steps to se…

c2d7cd2

…rve OR queries from client-side index.

Adding tests

41d0e29

Test for DNF computation.

90f7c50

Fix implementation of isFlatConjunction

ff52ecc

Adding integration tests for validation of composite queries.

dfda9f8

IndexDb manager tests for partial and full index.

9bc3336

Test query does not include documents with missing fields

d66abd4

Run prettier

e33263d

Add missing awaits

01c3487

Fixing argument validation for and . Updating tests for asserted erro…

7d56b57

…r messages.

Prettier

d01ff74

Removing duplicate test cases.

186fd92

Update proto with OR operator.

409b19c

Update protos with OR operator.

131f4be

MarkDuckworth added 3 commits November 3, 2022 16:54

Fix edge case a == 1 && a == 6

66bf749

Logic utils tests for in expansion.

968d133

Relaxing in restrictions.

934fbef

MarkDuckworth added the do-not-merge label Nov 4, 2022

MarkDuckworth assigned ehsannas Nov 4, 2022

ehsannas requested changes Nov 7, 2022

View reviewed changes

ehsannas assigned MarkDuckworth and unassigned ehsannas Nov 7, 2022

MarkDuckworth added 7 commits November 8, 2022 11:32

Fixed rogue comment.

5f37954

Comment cleanup.

ab5cad2

Comment cleanup.

5fa9c76

Test refactoring.

9c6395b

Merge branch 'markduckworth/or-queries-pr-9' into markduckworth/or-qu…

e711f06

…eries-relaxing-in-restrictions

Adding missing tests.

838f825

Adding and fixing tests.

433b283

ehsannas reviewed Nov 11, 2022

View reviewed changes

ehsannas approved these changes Nov 11, 2022

View reviewed changes

Base automatically changed from markduckworth/or-queries-pr-9 to markduckworth/or-queries November 11, 2022 18:01

MarkDuckworth requested review from dwyfrequency and hsubox76 as code owners November 11, 2022 18:01

Removing .only

9f5721e

Base automatically changed from markduckworth/or-queries to master November 22, 2022 21:58

Merge branch 'master' into markduckworth/or-queries-relaxing-in-restr…

1280052

…ictions

MarkDuckworth closed this Feb 9, 2023

MarkDuckworth mentioned this pull request Feb 9, 2023

OR queries - relaxing in restrictions #7024

Merged

firebase locked and limited conversation to collaborators Mar 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relaxing in restrictions. #6757

Relaxing in restrictions. #6757

MarkDuckworth commented Nov 4, 2022

changeset-bot bot commented Nov 4, 2022 •

edited

Loading

google-oss-bot commented Nov 4, 2022 •

edited

Loading

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Nov 4, 2022 •

edited

Loading

`@firebase/firestore`

`QueryCompositeFilterConstraint`

`QueryFieldFilterConstraint`

`and`

`or`

`query`

`where`

ehsannas Nov 11, 2022 •

edited

Loading

MarkDuckworth commented Feb 9, 2023

Relaxing in restrictions. #6757

Relaxing in restrictions. #6757

Conversation

MarkDuckworth commented Nov 4, 2022

changeset-bot bot commented Nov 4, 2022 • edited Loading

⚠️ No Changeset found

google-oss-bot commented Nov 4, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/firestore

@firebase/firestore-lite

bundle

firebase

Test Logs

google-oss-bot commented Nov 4, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/firestore

QueryCompositeFilterConstraint

QueryFieldFilterConstraint

and

or

query

where

Test Logs

ehsannas Nov 11, 2022 • edited Loading

Choose a reason for hiding this comment

MarkDuckworth commented Feb 9, 2023

changeset-bot bot commented Nov 4, 2022 •

edited

Loading

google-oss-bot commented Nov 4, 2022 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Nov 4, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`QueryCompositeFilterConstraint`

`QueryFieldFilterConstraint`

`and`

`or`

`query`

`where`

ehsannas Nov 11, 2022 •

edited

Loading