Updated base64 error to be more descriptive #6746

maneesht · 2022-11-01T23:55:05Z

When users of Expo and other similar environments don't support atob or btoa, polyfills are required, but the SDK doesn't provide this information to the user.

This PR checks whether atob is available and throws an error if it is not.

changeset-bot · 2022-11-01T23:55:08Z

🦋 Changeset detected

Latest commit: 033ffc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/storage	Patch
firebase	Patch
@firebase/storage-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…se/firebase-js-sdk into mtewani/fix-storage-error

google-oss-bot · 2022-11-02T00:15:46Z

Size Report ¹

Affected Products

@firebase/app-check
Type Base (9e9ee7b) Merge (f9428da) Diff
browser 25.6 kB 25.2 kB -365 B (-1.4%)
esm5 30.3 kB 30.0 kB -253 B (-0.8%)
main 31.5 kB 31.1 kB -385 B (-1.2%)
module 25.6 kB 25.2 kB -365 B (-1.4%)
@firebase/storage
Type Base (9e9ee7b) Merge (f9428da) Diff
browser 55.6 kB 56.0 kB +356 B (+0.6%)
esm5 61.9 kB 62.3 kB +354 B (+0.6%)
main 58.5 kB 58.5 kB +43 B (+0.1%)
module 55.6 kB 56.0 kB +356 B (+0.6%)

`bundle`

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
app-check (CustomProvider)	36.5 kB	36.2 kB	-282 B (-0.8%)
app-check (ReCaptchaEnterpriseProvider)	38.8 kB	38.5 kB	-364 B (-0.9%)
app-check (ReCaptchaV3Provider)	38.8 kB	38.4 kB	-364 B (-0.9%)
storage (uploadBytes)	46.5 kB	46.8 kB	+306 B (+0.7%)
storage (uploadBytesResumable)	56.5 kB	56.8 kB	+306 B (+0.5%)
storage (uploadString)	46.7 kB	47.0 kB	+306 B (+0.7%)

`firebase`

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
firebase-app-check-compat.js	23.1 kB	22.7 kB	-422 B (-1.8%)
firebase-app-check.js	21.8 kB	21.4 kB	-452 B (-2.1%)
firebase-compat.js	740 kB	740 kB	-132 B (-0.0%)
firebase-storage-compat.js	39.1 kB	39.4 kB	+297 B (+0.8%)
firebase-storage.js	38.7 kB	39.0 kB	+305 B (+0.8%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/T7O0cprDwj.html

google-oss-bot · 2022-11-02T00:32:13Z

Size Analysis Report ¹

Affected Products

`@firebase/app-check`

`CustomProvider`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	7.72 kB	7.52 kB	-206 B (-2.7%)
size-with-ext-deps	25.3 kB	25.1 kB	-212 B (-0.8%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

21 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

20 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getStateReference
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

+ getStateReference
- getState
- setState

`ReCaptchaEnterpriseProvider`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	11.3 kB	11.0 kB	-288 B (-2.6%)
size-with-ext-deps	28.7 kB	28.4 kB	-294 B (-1.0%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

34 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDurationString
getExchangeRecaptchaEnterpriseTokenRequest
getRecaptcha
getState
getToken$1
getToken$2
initTokenRefresher
initializeEnterprise
internalFactory
isValid
loadReCAPTCHAEnterpriseScript
makeDiv
makeDummyTokenResult
notifyTokenListeners
pad
queueWidgetRender
registerAppCheck
removeTokenListener
renderInvisibleWidget
setBackoff
setState
sleep
throwIfThrottled
write
writeTokenToIndexedDB
writeTokenToStorage

33 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDurationString
getExchangeRecaptchaEnterpriseTokenRequest
getRecaptcha
getStateReference
getToken$1
getToken$2
initTokenRefresher
initializeEnterprise
internalFactory
isValid
loadReCAPTCHAEnterpriseScript
makeDiv
makeDummyTokenResult
notifyTokenListeners
pad
queueWidgetRender
registerAppCheck
removeTokenListener
renderInvisibleWidget
setBackoff
sleep
throwIfThrottled
write
writeTokenToIndexedDB
writeTokenToStorage

+ getStateReference
- getState
- setState

`ReCaptchaV3Provider`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	11.2 kB	11.0 kB	-288 B (-2.6%)
size-with-ext-deps	28.7 kB	28.4 kB	-294 B (-1.0%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

34 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDurationString
getExchangeRecaptchaV3TokenRequest
getRecaptcha
getState
getToken$1
getToken$2
initTokenRefresher
initializeV3
internalFactory
isValid
loadReCAPTCHAV3Script
makeDiv
makeDummyTokenResult
notifyTokenListeners
pad
queueWidgetRender
registerAppCheck
removeTokenListener
renderInvisibleWidget
setBackoff
setState
sleep
throwIfThrottled
write
writeTokenToIndexedDB
writeTokenToStorage

33 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDurationString
getExchangeRecaptchaV3TokenRequest
getRecaptcha
getStateReference
getToken$1
getToken$2
initTokenRefresher
initializeV3
internalFactory
isValid
loadReCAPTCHAV3Script
makeDiv
makeDummyTokenResult
notifyTokenListeners
pad
queueWidgetRender
registerAppCheck
removeTokenListener
renderInvisibleWidget
setBackoff
sleep
throwIfThrottled
write
writeTokenToIndexedDB
writeTokenToStorage

+ getStateReference
- getState
- setState

`getToken`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	7.35 kB	7.15 kB	-206 B (-2.8%)
size-with-ext-deps	24.5 kB	24.2 kB	-212 B (-0.9%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

22 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

21 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getStateReference
getToken
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

+ getStateReference
- getState
- setState

`initializeAppCheck`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	11.2 kB	10.9 kB	-276 B (-2.5%)
size-with-ext-deps	35.5 kB	35.2 kB	-282 B (-0.8%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

35 dependencies

_activate
addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDebugState
getDebugToken
getExchangeDebugTokenRequest
getState
getToken$2
initTokenRefresher
initializeAppCheck
initializeDebugMode
internalFactory
isDebugMode
isValid
makeDummyTokenResult
notifyTokenListeners
read
readDebugTokenFromIndexedDB
readOrCreateDebugTokenFromStorage
readTokenFromIndexedDB
readTokenFromStorage
registerAppCheck
removeTokenListener
setState
sleep
write
writeDebugTokenToIndexedDB
writeTokenToIndexedDB
writeTokenToStorage

35 dependencies

_activate
addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDebugState
getDebugToken
getExchangeDebugTokenRequest
getStateReference
getToken$2
initTokenRefresher
initializeAppCheck
initializeDebugMode
internalFactory
isDebugMode
isValid
makeDummyTokenResult
notifyTokenListeners
read
readDebugTokenFromIndexedDB
readOrCreateDebugTokenFromStorage
readTokenFromIndexedDB
readTokenFromStorage
registerAppCheck
removeTokenListener
setInitialState
sleep
write
writeDebugTokenToIndexedDB
writeTokenToIndexedDB
writeTokenToStorage

+ getStateReference
+ setInitialState
- getState
- setState

`onTokenChanged`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	7.45 kB	7.24 kB	-206 B (-2.8%)
size-with-ext-deps	24.5 kB	24.3 kB	-212 B (-0.9%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

22 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
onTokenChanged
registerAppCheck
removeTokenListener
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

21 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getStateReference
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
onTokenChanged
registerAppCheck
removeTokenListener
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

+ getStateReference
- getState
- setState

`setTokenAutoRefreshEnabled`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	7.48 kB	7.23 kB	-246 B (-3.3%)
size-with-ext-deps	24.6 kB	24.3 kB	-253 B (-1.0%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

22 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getState
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setState
setTokenAutoRefreshEnabled
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

21 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
factory
formatDummyToken
getDBPromise
getStateReference
getToken$2
initTokenRefresher
internalFactory
isValid
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
setTokenAutoRefreshEnabled
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

+ getStateReference
- getState
- setState

`@firebase/storage`

`_FbsBlob`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	14.1 kB	14.4 kB	+305 B (+2.2%)
size-with-ext-deps	31.1 kB	31.4 kB	+306 B (+1.0%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

40 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
base64Bytes_
canceled
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
endsWith
extractBucket
factory
getBlob$1
getBlobBuilder
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isRetryStatusCode
isString
lastComponent
makeQueryString
makeRequest
parent
percentEncodedBytes_
prependCode
registerStorage
retryLimitExceeded
sliceBlob
start
stop
unknown
utf8Bytes_
validateNumber

41 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
base64Bytes_
canceled
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
endsWith
extractBucket
factory
getBlob$1
getBlobBuilder
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isRetryStatusCode
isString
lastComponent
makeQueryString
makeRequest
missingPolyFill
parent
percentEncodedBytes_
prependCode
registerStorage
retryLimitExceeded
sliceBlob
start
stop
unknown
utf8Bytes_
validateNumber

+ missingPolyFill

`_UploadTask`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	29.6 kB	29.9 kB	+305 B (+1.0%)
size-with-ext-deps	46.7 kB	47.0 kB	+306 B (+0.7%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

74 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
async
base64Bytes_
canceled
cannotSliceBlob
checkResumeHeader_
continueResumableUpload
createResumableUpload
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
getMetadata$2
getResumableUploadStatus
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isFunction
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
serverFileWrongSize
sharedErrorHandler
sliceBlob
start
stop
taskStateFromInternalTaskState
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
utf8Bytes_
validateNumber
xformPath

75 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
async
base64Bytes_
canceled
cannotSliceBlob
checkResumeHeader_
continueResumableUpload
createResumableUpload
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
getMetadata$2
getResumableUploadStatus
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isFunction
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
missingPolyFill
multipartUpload
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
serverFileWrongSize
sharedErrorHandler
sliceBlob
start
stop
taskStateFromInternalTaskState
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
utf8Bytes_
validateNumber
xformPath

+ missingPolyFill

`_dataFromString`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	12.3 kB	12.6 kB	+306 B (+2.5%)
size-with-ext-deps	29.2 kB	29.5 kB	+306 B (+1.0%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

34 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
base64Bytes_
canceled
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
endsWith
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
parent
percentEncodedBytes_
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
utf8Bytes_
validateNumber

35 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addVersionHeader_
appDeleted
base64Bytes_
canceled
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
endsWith
extractBucket
factory
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isRetryStatusCode
lastComponent
makeQueryString
makeRequest
missingPolyFill
parent
percentEncodedBytes_
prependCode
registerStorage
retryLimitExceeded
start
stop
unknown
utf8Bytes_
validateNumber

+ missingPolyFill

`uploadBytes`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	19.8 kB	20.1 kB	+314 B (+1.6%)
size-with-ext-deps	36.9 kB	37.2 kB	+306 B (+0.8%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

65 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
base64Bytes_
canceled
cannotSliceBlob
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
sliceBlob
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytes
uploadBytes$1
utf8Bytes_
validateNumber
xformPath

66 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
base64Bytes_
canceled
cannotSliceBlob
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
missingPolyFill
multipartUpload
newTextConnection
noXform_
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
sliceBlob
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytes
uploadBytes$1
utf8Bytes_
validateNumber
xformPath

+ missingPolyFill

`uploadBytesResumable`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	29.8 kB	30.1 kB	+305 B (+1.0%)
size-with-ext-deps	46.9 kB	47.2 kB	+306 B (+0.7%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

76 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
async
base64Bytes_
canceled
cannotSliceBlob
checkResumeHeader_
continueResumableUpload
createResumableUpload
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
getMetadata$2
getResumableUploadStatus
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isFunction
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
serverFileWrongSize
sharedErrorHandler
sliceBlob
start
stop
taskStateFromInternalTaskState
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytesResumable
uploadBytesResumable$1
utf8Bytes_
validateNumber
xformPath

77 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
async
base64Bytes_
canceled
cannotSliceBlob
checkResumeHeader_
continueResumableUpload
createResumableUpload
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
getMetadata$2
getResumableUploadStatus
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isFunction
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
missingPolyFill
multipartUpload
newTextConnection
noXform_
objectErrorHandler
objectNotFound
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
serverFileWrongSize
sharedErrorHandler
sliceBlob
start
stop
taskStateFromInternalTaskState
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytesResumable
uploadBytesResumable$1
utf8Bytes_
validateNumber
xformPath

+ missingPolyFill

`uploadString`

Size

Type	Base (`9e9ee7b`)	Merge (`f9428da`)	Diff
size	20.0 kB	20.3 kB	+315 B (+1.6%)
size-with-ext-deps	37.1 kB	37.4 kB	+306 B (+0.8%)

Dependency

Type Base (9e9ee7b) Merge (f9428da) Diff

functions

66 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
base64Bytes_
canceled
cannotSliceBlob
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
multipartUpload
newTextConnection
noXform_
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
sliceBlob
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytes$1
uploadString
uploadString$1
utf8Bytes_
validateNumber
xformPath

67 dependencies

addAppCheckHeader_
addAuthHeader_
addGmpidHeader_
addRef
addVersionHeader_
appDeleted
base64Bytes_
canceled
cannotSliceBlob
dataFromString
dataURLBytes_
dataURLContentType_
decodeBase64
determineContentType_
endsWith
extractBucket
factory
fromResource
fromResourceString
getBlob$1
getBlobBuilder
getMappings
handlerCheck
internalError
invalidArgument
invalidDefaultBucket
invalidFormat
invalidRootOperation
invalidUrl
isJustDef
isNativeBlob
isNativeBlobDefined
isNonArrayObject
isRetryStatusCode
isString
jsonObjectOrNull
lastComponent
makeQueryString
makeRequest
makeUrl
metadataForUpload_
metadataHandler
missingPolyFill
multipartUpload
newTextConnection
noXform_
parent
percentEncodedBytes_
prependCode
quotaExceeded
registerStorage
retryLimitExceeded
sharedErrorHandler
sliceBlob
start
stop
toResourceString
unauthenticated
unauthorized
unauthorizedApp
unknown
uploadBytes$1
uploadString
uploadString$1
utf8Bytes_
validateNumber
xformPath

+ missingPolyFill

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/a73wI3Udd5.html

Yuangwang

Thanks for the fix!

egilmorez

A nit on the wording, but LG, thanks!

packages/storage/src/implementation/error.ts

Updated base64 error to be more descriptive

509eec8

maneesht requested a review from tonyjhuang as a code owner November 1, 2022 23:55

Create long-shirts-explode.md

246cb1c

maneesht requested a review from egilmorez as a code owner November 1, 2022 23:56

maneesht added 3 commits November 1, 2022 17:00

Fixed formatting

8240a83

Merge branch 'mtewani/fix-storage-error' of https://github.com/fireba…

80f5777

…se/firebase-js-sdk into mtewani/fix-storage-error

Removed only

2b110f9

maneesht added 4 commits November 2, 2022 13:03

Fixed boolean

d3268d6

Fixed formatting

39e265b

Removed storageerror import

f430e0b

Removed console log

7d56af5

tonyjhuang approved these changes Nov 4, 2022

View reviewed changes

tonyjhuang requested a review from Yuangwang November 4, 2022 12:12

Yuangwang approved these changes Nov 4, 2022

View reviewed changes

egilmorez approved these changes Nov 8, 2022

View reviewed changes

packages/storage/src/implementation/error.ts Outdated Show resolved Hide resolved

Updated wording

033ffc4

maneesht merged commit 8876b78 into master Nov 9, 2022

maneesht deleted the mtewani/fix-storage-error branch November 9, 2022 18:05

google-oss-bot mentioned this pull request Nov 9, 2022

Version Packages #6767

Merged

firebase locked and limited conversation to collaborators Dec 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated base64 error to be more descriptive #6746

Updated base64 error to be more descriptive #6746

maneesht commented Nov 1, 2022

changeset-bot bot commented Nov 1, 2022 •

edited

Loading

google-oss-bot commented Nov 2, 2022 •

edited

Loading

`@firebase/app-check`

`@firebase/storage`

`bundle`

`firebase`

google-oss-bot commented Nov 2, 2022 •

edited

Loading

`@firebase/app-check`

`CustomProvider`

`ReCaptchaEnterpriseProvider`

`ReCaptchaV3Provider`

`getToken`

`initializeAppCheck`

`onTokenChanged`

`setTokenAutoRefreshEnabled`

`@firebase/storage`

`_FbsBlob`

`_UploadTask`

`_dataFromString`

`uploadBytes`

`uploadBytesResumable`

`uploadString`

Yuangwang left a comment

egilmorez left a comment

Updated base64 error to be more descriptive #6746

Updated base64 error to be more descriptive #6746

Conversation

maneesht commented Nov 1, 2022

changeset-bot bot commented Nov 1, 2022 • edited Loading

🦋 Changeset detected

google-oss-bot commented Nov 2, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/app-check

@firebase/storage

bundle

firebase

Test Logs

google-oss-bot commented Nov 2, 2022 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/app-check

CustomProvider

ReCaptchaEnterpriseProvider

ReCaptchaV3Provider

getToken

initializeAppCheck

onTokenChanged

setTokenAutoRefreshEnabled

@firebase/storage

_FbsBlob

_UploadTask

_dataFromString

uploadBytes

uploadBytesResumable

uploadString

Test Logs

Yuangwang left a comment

Choose a reason for hiding this comment

egilmorez left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Nov 1, 2022 •

edited

Loading

google-oss-bot commented Nov 2, 2022 •

edited

Loading

Size Report ¹

`@firebase/app-check`

`@firebase/storage`

`bundle`

`firebase`

google-oss-bot commented Nov 2, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/app-check`

`CustomProvider`

`ReCaptchaEnterpriseProvider`

`ReCaptchaV3Provider`

`getToken`

`initializeAppCheck`

`onTokenChanged`

`setTokenAutoRefreshEnabled`

`@firebase/storage`

`_FbsBlob`

`_UploadTask`

`_dataFromString`

`uploadBytes`

`uploadBytesResumable`

`uploadString`