-
Notifications
You must be signed in to change notification settings - Fork 927
Remove json path and fix process check #6665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9b9875c The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix bugs introduced in #6526:
Remove
__FIREBASE_DEFAULTS_PATH__
option to point to a JSON file path for modular autoinit defaults. This causes webpack warnings about dynamicrequire()
s although the code is only meant to take that path in a Node environment. (See Warning: Critical dependency: the request of a dependency is an expression #6660). If we can figure out a way around this, we can add the functionality back.Fix the
process
check to be more robust and handle environments that haveprocess
but do not haveprocess.env
. This incorporates the fix in PR Fix modular autoinit breakage #6663Fixes #6660
Fixes #6662