Skip to content

fix: #6657 Cannot read property 'controller' of undefined #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nilptr
Copy link

@nilptr nilptr commented Oct 7, 2022

fix #6657

Discussion

NA

Testing

NA

API Changes

NA

@nilptr nilptr requested a review from jposuna as a code owner October 7, 2022 15:48
@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022

🦋 Changeset detected

Latest commit: 0fd4091

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/performance Patch
firebase Patch
@firebase/performance-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nilptr nilptr requested a review from egilmorez as a code owner October 7, 2022 15:56
@dwyfrequency
Copy link
Contributor

@nilptr expanded upon your PR with some unit tests #6723. Please let me know if this matches your expectations

@nilptr
Copy link
Author

nilptr commented Oct 30, 2022

@dwyfrequency Yes, it matches. Thanks. I'll close this pull request.

@nilptr nilptr closed this Oct 30, 2022
@firebase firebase locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'controller' of undefined
2 participants