Skip to content

Remove excluded packages from doc index.md #6651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Oct 3, 2022

Removes the 3 packages from the v9 docs index page that shouldn't have a public link (they're already removed from the TOC and the generated md files are also removed)

This is the page: https://firebase.google.com/docs/reference/js

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022

⚠️ No Changeset found

Latest commit: df84a00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@hsubox76 hsubox76 marked this pull request as ready for review October 3, 2022 21:59
@hsubox76 hsubox76 requested a review from dwyfrequency as a code owner October 3, 2022 21:59
@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 417a5d4 into master Oct 6, 2022
@hsubox76 hsubox76 deleted the ch-doc-index-fix branch October 6, 2022 19:55
@firebase firebase locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants