Update prune-dts to allow beta APIs #6633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsNo changes between base commit (c6ba6fc) and merge commit (f77e2bc).Test Logs |
Merged
wu-hui
approved these changes
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update prune-dts (only used by Firestore I think) to allow beta APIs to get through (this seems to be the default behavior when using api-documenter). I think this is because api-documenter uses the *.api.json files and prune-dts filters out beta APIs before they even get into the json, whereas api-extractor puts everything in the json, and only filters what it puts into the public *.d.ts file.
Also an overload was recently added to
getFirestore()which causes{@link getFirestore}to no longer work, leaving only a blank space in its place in reference docs. Fixed this by specifying the overload.Also regenerated the firestore.api.md file after these changes.