Skip to content

Demo-app readme fix #6630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2022
Merged

Demo-app readme fix #6630

merged 2 commits into from
Sep 28, 2022

Conversation

bhparijat
Copy link
Contributor

Updated build step for auth package in the readme file

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: cbc22df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bhparijat bhparijat changed the base branch from master to mfa-totp September 27, 2022 06:07
@bhparijat bhparijat requested review from prameshj and removed request for sam-gc September 27, 2022 06:08
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 27, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (70cbc31) and merge commit (ef846f3).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2ADTheXsfb.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 27, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (70cbc31) and merge commit (ef846f3).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/u8Qq1rBmzc.html

@bhparijat bhparijat requested a review from prameshj September 27, 2022 23:28
prameshj
prameshj approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@bhparijat bhparijat merged commit fe42bac into mfa-totp Sep 28, 2022
@bhparijat bhparijat deleted the demoapp-readme-fix branch September 28, 2022 23:06
bhparijat added a commit that referenced this pull request Oct 11, 2022
@bhparijat
Demo-app readme fix (#6630)
6dd2ecf 
* updated readme
bhparijat added a commit that referenced this pull request Oct 13, 2022
@bhparijat
Demo-app readme fix (#6630)
b0e4584 
* updated readme
@firebase firebase locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prameshj prameshj prameshj approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhparijat @google-oss-bot @prameshj