Skip to content

Update comment in GithubAuthProvider javascript example #6628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2022
Merged

Update comment in GithubAuthProvider javascript example #6628

merged 1 commit into from
Sep 28, 2022

Conversation

dwyfrequency
Copy link
Contributor

Resolving inconsistency in GithubAuthProvider example in compat docs

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022

⚠️ No Changeset found

Latest commit: ce0f49a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dwyfrequency dwyfrequency changed the title Update comment in javascript example Update comment in GithubAuthProvider javascript example Sep 26, 2022
@dwyfrequency dwyfrequency marked this pull request as ready for review September 26, 2022 16:40
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (a491888) and merge commit (be8d47d).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8CQkV2CxU2.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (a491888) and merge commit (be8d47d).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eXIhTC4blF.html

@dwyfrequency dwyfrequency merged commit 516fe9c into master Sep 28, 2022
@dwyfrequency dwyfrequency deleted the jd-update-gh-auth-ex2 branch September 28, 2022 16:13
@firebase firebase locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwyfrequency @google-oss-bot @hsubox76