Skip to content

Fix document change leads to time travel across multiple tabs #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2022
Merged

Fix document change leads to time travel across multiple tabs #6619

merged 2 commits into from
Sep 26, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Sep 21, 2022 •
edited
Loading

Fix: #6511

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 22af81f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wu-hui wu-hui requested a review from egilmorez as a code owner September 21, 2022 19:09
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 21, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (b3951c6)Merge (e7b7c9e)Diff
    browser264 kB264 kB+13 B (+0.0%)
    esm5327 kB327 kB+13 B (+0.0%)
    main527 kB527 kB+61 B (+0.0%)
    module264 kB264 kB+13 B (+0.0%)
    react-native264 kB264 kB+13 B (+0.0%)

  • bundle

    TypeBase (b3951c6)Merge (e7b7c9e)Diff
    firestore (Persistence)273 kB273 kB+13 B (+0.0%)
    firestore (Query Cursors)209 kB209 kB+13 B (+0.0%)
    firestore (Query)211 kB211 kB+13 B (+0.0%)
    firestore (Read data once)199 kB199 kB+13 B (+0.0%)
    firestore (Realtime updates)201 kB201 kB+13 B (+0.0%)

  • firebase

    TypeBase (b3951c6)Merge (e7b7c9e)Diff
    firebase-compat.js738 kB738 kB+13 B (+0.0%)
    firebase-firestore-compat.js313 kB313 kB+13 B (+0.0%)
    firebase-firestore.js311 kB311 kB+13 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WqJEhd55kG.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 21, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (b3951c6)Merge (e7b7c9e)Diff
      size206 kB206 kB+13 B (+0.0%)
      size-with-ext-deps266 kB266 kB+13 B (+0.0%)

    • getDoc

      Size

      TypeBase (b3951c6)Merge (e7b7c9e)Diff
      size132 kB132 kB+13 B (+0.0%)
      size-with-ext-deps192 kB192 kB+13 B (+0.0%)

    • getDocFromServer

      Size

      TypeBase (b3951c6)Merge (e7b7c9e)Diff
      size132 kB132 kB+13 B (+0.0%)
      size-with-ext-deps192 kB192 kB+13 B (+0.0%)

    • getDocs

      Size

      TypeBase (b3951c6)Merge (e7b7c9e)Diff
      size134 kB134 kB+13 B (+0.0%)
      size-with-ext-deps193 kB193 kB+13 B (+0.0%)

    • getDocsFromCache

      Size

      TypeBase (b3951c6)Merge (e7b7c9e)Diff
      size96.3 kB96.3 kB+13 B (+0.0%)
      size-with-ext-deps155 kB155 kB+13 B (+0.0%)

    • getDocsFromServer

      Size

      TypeBase (b3951c6)Merge (e7b7c9e)Diff
      size134 kB134 kB+13 B (+0.0%)
      size-with-ext-deps193 kB193 kB+13 B (+0.0%)

    • onSnapshot

      Size

      TypeBase (b3951c6)Merge (e7b7c9e)Diff
      size134 kB134 kB+13 B (+0.0%)
      size-with-ext-deps194 kB194 kB+13 B (+0.0%)

    • onSnapshotsInSync

      Size

      TypeBase (b3951c6)Merge (e7b7c9e)Diff
      size124 kB124 kB+13 B (+0.0%)
      size-with-ext-deps183 kB184 kB+13 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0jUCew5yPO.html

@wu-hui wu-hui requested a review from dconeybe September 22, 2022 16:02
dconeybe
dconeybe approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice fix! I don't think I would have ever found this root cause.

@wu-hui wu-hui merged commit c6ba6fc into master Sep 26, 2022
@wu-hui wu-hui deleted the wuandy/MultiTabChangeTimeTravel branch September 26, 2022 17:47
dconeybe pushed a commit that referenced this pull request Sep 27, 2022
@wu-hui @dconeybe
Fix document change leads to time travel across multiple tabs (#6619)
bb87268 
* Fix document change leads to time travel across multiple tabs

* Changeset
@google-oss-bot google-oss-bot mentioned this pull request Sep 29, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@dconeybe dconeybe

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wu-hui @google-oss-bot @dconeybe