Skip to content

Fix index backfilling frequency. #6585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2022
Merged

Fix index backfilling frequency. #6585

merged 3 commits into from
Sep 7, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Sep 6, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f8119c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wu-hui wu-hui requested a review from tom-andersen September 6, 2022 14:42
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022 •
edited
Loading

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 6, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (87c90a7)Merge (765debe)Diff
    browser264 kB264 kB+4 B (+0.0%)
    esm5327 kB327 kB+4 B (+0.0%)
    main526 kB526 kB+9 B (+0.0%)
    module264 kB264 kB+4 B (+0.0%)
    react-native264 kB264 kB+4 B (+0.0%)

  • bundle

    TypeBase (87c90a7)Merge (765debe)Diff
    firestore (Persistence)274 kB274 kB+4 B (+0.0%)

  • firebase

    TypeBase (87c90a7)Merge (765debe)Diff
    firebase-compat.js739 kB739 kB+4 B (+0.0%)
    firebase-firestore-compat.js314 kB314 kB+4 B (+0.0%)
    firebase-firestore.js313 kB313 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/O2FyTgXA4M.html

@wu-hui wu-hui requested a review from egilmorez as a code owner September 6, 2022 15:54
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 6, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • enableIndexedDbPersistence

      Size

      TypeBase (87c90a7)Merge (765debe)Diff
      size174 kB174 kB+4 B (+0.0%)
      size-with-ext-deps235 kB235 kB+4 B (+0.0%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (87c90a7)Merge (765debe)Diff
      size207 kB207 kB+4 B (+0.0%)
      size-with-ext-deps268 kB268 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EwmScHB1ip.html

@wu-hui wu-hui removed the request for review from egilmorez September 6, 2022 17:22
tom-andersen
tom-andersen reviewed Sep 7, 2022
View reviewed changes
packages/firestore/src/local/index_backfiller.ts
@@ -35,10 +35,10 @@ import { isIndexedDbTransactionError } from './simple_db';
const LOG_TAG = 'IndexBackiller';

/** How long we wait to try running index backfill after SDK initialization. */
const INITIAL_BACKFILL_DELAY_MS = 15;
const INITIAL_BACKFILL_DELAY_MS = 15 * 1000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think '15_000' is a cleaner way to write this.

tom-andersen
tom-andersen approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, that is a personal preference.

@tom-andersen tom-andersen assigned wu-hui and unassigned tom-andersen Sep 7, 2022
@wu-hui wu-hui merged commit 2bdbd44 into master Sep 7, 2022
@wu-hui wu-hui deleted the wuandy/FixBackfillFreq branch September 7, 2022 18:43
@MarkDuckworth MarkDuckworth mentioned this pull request Sep 16, 2022
Closed
@ehsannas
Copy link
Contributor

This warrants a changelog entry; it has already been released though.

bhparijat pushed a commit that referenced this pull request Sep 23, 2022
@wu-hui @bhparijat
Fix index backfilling frequency. (#6585)
5d4c8b0 
* Fix index backfilling frequency.

* Add changeset

* Delete happy-forks-greet.md
@firebase firebase locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@wu-hui wu-hui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wu-hui @google-oss-bot @ehsannas @tom-andersen