Skip to content

Fix MFA endpoint names to be mfa provider-agnostic. #6572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix MFA endpoint names to be mfa provider-agnostic. #6572

merged 1 commit into from
Aug 31, 2022

Conversation

prameshj
Copy link
Contributor

We will have other MFA providers than phone in the near future.

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 84fdc79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sam-gc
sam-gc approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@prameshj
Fix MFA endpoint names to be mfa provider-agnostic.
84fdc79 
We will have other MFA providers than phone in the near future.
@prameshj
Copy link
Contributor Author

cc @bhparijat

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 30, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (ca1b0c8) and merge commit (a3cfc5c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/s3gRnGUrmw.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 30, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (ca1b0c8) and merge commit (a3cfc5c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zuigpndawd.html

@prameshj prameshj merged commit 04dcdbb into master Aug 31, 2022
@prameshj prameshj deleted the mfa-endpoints branch August 31, 2022 18:20
@prameshj
Copy link
Contributor Author

Ignoring firestore test failures above, since those are connectivity-related and this PR does not change any firestore code.

@firebase firebase locked and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prameshj @google-oss-bot @sam-gc @yuchenshi