Skip to content

Mila/count add tests #6566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 30, 2022
Merged

Mila/count add tests #6566

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
509745e
add tests for orderby and startAt/endAt
milaGGL Aug 25, 2022
8dad0f3
add collectionGroup test
milaGGL Aug 25, 2022
0eb6c3e
run prettier
milaGGL Aug 25, 2022
7bebf45
correct typo
milaGGL Aug 25, 2022
43525f7
add test for running count query on terminated firestore
milaGGL Aug 26, 2022
501de77
resolve comments
milaGGL Aug 26, 2022
5626326
add test demo
milaGGL Aug 26, 2022
b84d374
rename snapshot to promise
milaGGL Aug 29, 2022
88d6d01
update the last test
milaGGL Aug 30, 2022
db7a85b
Merge branch 'mila/count' into mila/count-add-tests
milaGGL Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 160 additions & 12 deletions packages/firestore/test/lite/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2046,20 +2046,12 @@ describe('withConverter() support', () => {
});

describe('countQuery()', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' },
{ author: 'authorB', title: 'titleD' },
{ author: 'authorB', title: 'titleE' }
];

it('AggregateQuery and AggregateQuerySnapshot inherits the original query', () => {
return withTestCollection(async coll => {
const query_ = query(coll);
const countQuery_ = countQuery(query_);
expect(countQuery_.query).to.equal(query_);
const snapshot = await getAggregateFromServerDirect(countQuery_);
expect(countQuery_.query).to.equal(query_);
expect(snapshot.query).to.equal(countQuery_);
expect(snapshot.query.query).to.equal(query_);
});
Expand All @@ -2073,15 +2065,25 @@ describe('countQuery()', () => {
});
});

it('test collection count with 5 docs', () => {
it('test collection count with 3 docs', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const countQuery_ = countQuery(query(collection));
const snapshot = await getAggregateFromServerDirect(countQuery_);
expect(snapshot.getCount()).to.equal(5);
expect(snapshot.getCount()).to.equal(3);
});
});

it('test collection count with filter', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query_ = query(collection, where('author', '==', 'authorA'));
const countQuery_ = countQuery(query_);
Expand All @@ -2091,6 +2093,11 @@ describe('countQuery()', () => {
});

it('test collection count with filter and a small limit size', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query_ = query(
collection,
Expand All @@ -2104,6 +2111,11 @@ describe('countQuery()', () => {
});

it('test collection count with filter and a large limit size', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query_ = query(
collection,
Expand All @@ -2116,7 +2128,87 @@ describe('countQuery()', () => {
});
});

it('count with order by', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: null },
{ author: 'authorB' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query_ = query(collection, orderBy('title'));
const countQuery_ = countQuery(query_);
const snapshot = await getAggregateFromServerDirect(countQuery_);
expect(snapshot.getCount()).to.equal(3);
});
});

it('count with order by and startAt', () => {
const testDocs = [
{ id: 3, author: 'authorA', title: 'titleA' },
{ id: 1, author: 'authorA', title: 'titleB' },
{ id: 2, author: 'authorB', title: 'titleC' },
{ id: null, author: 'authorB', title: 'titleD' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query_ = query(collection, orderBy('id'), startAt(2));
const countQuery_ = countQuery(query_);
const snapshot = await getAggregateFromServerDirect(countQuery_);
expect(snapshot.getCount()).to.equal(2);
});
});

it('count with order by and startAfter', () => {
const testDocs = [
{ id: 3, author: 'authorA', title: 'titleA' },
{ id: 1, author: 'authorA', title: 'titleB' },
{ id: 2, author: 'authorB', title: 'titleC' },
{ id: null, author: 'authorB', title: 'titleD' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query_ = query(collection, orderBy('id'), startAfter(2));
const countQuery_ = countQuery(query_);
const snapshot = await getAggregateFromServerDirect(countQuery_);
expect(snapshot.getCount()).to.equal(1);
});
});

it('count with order by and endAt', () => {
const testDocs = [
{ id: 3, author: 'authorA', title: 'titleA' },
{ id: 1, author: 'authorA', title: 'titleB' },
{ id: 2, author: 'authorB', title: 'titleC' },
{ id: null, author: 'authorB', title: 'titleD' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query_ = query(collection, orderBy('id'), startAt(1), endAt(2));
const countQuery_ = countQuery(query_);
const snapshot = await getAggregateFromServerDirect(countQuery_);
expect(snapshot.getCount()).to.equal(2);
});
});

it('count with order by and endBefore', () => {
const testDocs = [
{ id: 3, author: 'authorA', title: 'titleA' },
{ id: 1, author: 'authorA', title: 'titleB' },
{ id: 2, author: 'authorB', title: 'titleC' },
{ id: null, author: 'authorB', title: 'titleD' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query_ = query(collection, orderBy('id'), startAt(1), endBefore(2));
const countQuery_ = countQuery(query_);
const snapshot = await getAggregateFromServerDirect(countQuery_);
expect(snapshot.getCount()).to.equal(1);
});
});

it('test collection count with converter on query', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query_ = query(
collection,
Expand All @@ -2128,7 +2220,33 @@ describe('countQuery()', () => {
});
});

it('count query with collection groups', () => {
return withTestDb(async db => {
const collectionGroupId = doc(collection(db, 'countTest')).id;
const docPaths = [
`${collectionGroupId}/cg-doc1`,
`abc/123/${collectionGroupId}/cg-doc2`,
`zzz${collectionGroupId}/cg-doc3`,
`abc/123/zzz${collectionGroupId}/cg-doc4`,
`abc/123/zzz/${collectionGroupId}`
];
const batch = writeBatch(db);
for (const docPath of docPaths) {
batch.set(doc(db, docPath), { x: 1 });
}
await batch.commit();
const countQuery_ = countQuery(collectionGroup(db, collectionGroupId));
const snapshot = await getAggregateFromServerDirect(countQuery_);
expect(snapshot.getCount()).to.equal(2);
});
});

it('aggregateQueryEqual on same queries', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query1 = query(collection, where('author', '==', 'authorA'));
const query2 = query(collection, where('author', '==', 'authorA'));
Expand All @@ -2139,6 +2257,11 @@ describe('countQuery()', () => {
});

it('aggregateQueryEqual on different queries', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query1 = query(collection, where('author', '==', 'authorA'));
const query2 = query(collection, where('author', '==', 'authorB'));
Expand All @@ -2149,6 +2272,11 @@ describe('countQuery()', () => {
});

it('aggregateQuerySnapshotEqual on same queries', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query1 = query(collection, where('author', '==', 'authorA'));
const query2 = query(collection, where('author', '==', 'authorA'));
Expand All @@ -2164,6 +2292,11 @@ describe('countQuery()', () => {
});

it('aggregateQuerySnapshotEqual on different queries', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const query1 = query(collection, where('author', '==', 'authorA'));
const query2 = query(collection, where('author', '==', 'authorB'));
Expand All @@ -2180,8 +2313,23 @@ describe('countQuery()', () => {
await terminate(collection.firestore);
const countQuery_ = countQuery(query(collection));
expect(() => getAggregateFromServerDirect(countQuery_)).to.throw(
'The client has already been terminated'
'The client has already been terminated.'
);
});
});

it('terminate Firestore while calling count query', () => {
const testDocs = [
{ author: 'authorA', title: 'titleA' },
{ author: 'authorA', title: 'titleB' },
{ author: 'authorB', title: 'titleC' }
];
return withTestCollectionAndInitialData(testDocs, async collection => {
const countQuery_ = countQuery(query(collection));
const promise = getAggregateFromServerDirect(countQuery_);
await terminate(collection.firestore);
const snapshot = await promise;
expect(snapshot.getCount()).to.equal(3);
});
});
});