Skip to content

Add public methods to support TOTP as a multi-factor provider. #6547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2022
Merged

Add public methods to support TOTP as a multi-factor provider. #6547

merged 1 commit into from
Aug 31, 2022

Conversation

bhparijat
Copy link
Contributor

Added basic structure for implementing TOTP MFA

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8bade53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 18, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (ca1b0c8)Merge (adbca0f)Diff
    browser155 kB155 kB+12 B (+0.0%)
    cordova183 kB183 kB+12 B (+0.0%)
    esm5203 kB203 kB+12 B (+0.0%)
    main148 kB148 kB+12 B (+0.0%)
    module155 kB155 kB+12 B (+0.0%)
    react-native168 kB168 kB+12 B (+0.0%)

  • @firebase/auth/cordova

    TypeBase (ca1b0c8)Merge (adbca0f)Diff
    browser183 kB183 kB+12 B (+0.0%)
    module183 kB183 kB+12 B (+0.0%)

  • @firebase/auth/internal

    TypeBase (ca1b0c8)Merge (adbca0f)Diff
    browser166 kB166 kB+12 B (+0.0%)
    esm5216 kB216 kB+12 B (+0.0%)
    main184 kB184 kB+12 B (+0.0%)
    module166 kB166 kB+12 B (+0.0%)

  • @firebase/auth/react-native

    TypeBase (ca1b0c8)Merge (adbca0f)Diff
    browser168 kB168 kB+12 B (+0.0%)
    module168 kB168 kB+12 B (+0.0%)

  • firebase

    TypeBase (ca1b0c8)Merge (adbca0f)Diff
    firebase-auth-cordova.js137 kB137 kB+12 B (+0.0%)
    firebase-auth-react-native.js148 kB148 kB+12 B (+0.0%)
    firebase-auth.js116 kB116 kB+12 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FqjEHCMNE5.html

sam-gc
sam-gc requested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run yarn format from the base directory. Try to also keep the comments under 80 characters as well (I don't think the formatter will update comments)

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 18, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • FactorId

      Size

      TypeBase (ca1b0c8)Merge (adbca0f)Diff
      size31.4 kB31.4 kB+12 B (+0.0%)
      size-with-ext-deps51.2 kB51.2 kB+12 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/soLpLZPo43.html

prameshj
prameshj reviewed Aug 18, 2022
View reviewed changes
@prameshj prameshj changed the base branch from master to mfa-totp August 18, 2022 23:32
@prameshj prameshj changed the base branch from mfa-totp to master August 18, 2022 23:33
@prameshj prameshj changed the base branch from master to mfa-totp August 18, 2022 23:34
@prameshj
Copy link
Contributor

Changed the base branch to mfa-totp instead of master since we are committing this to a feature branch. We will merge to master closer to release.

renkelvin
renkelvin reviewed Aug 19, 2022
View reviewed changes
Copy link

@renkelvin renkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and please remove packages/auth/demo/yarn.lock from the diff.

sam-gc
sam-gc reviewed Aug 19, 2022
View reviewed changes
@bhparijat bhparijat force-pushed the parijat-feature2master-totp branch 2 times, most recently from 92ff805 to 4544ba5 Compare August 19, 2022 20:30
@bhparijat bhparijat requested a review from sam-gc August 19, 2022 20:59
sam-gc
sam-gc approved these changes Aug 19, 2022
View reviewed changes
@bhparijat bhparijat requested a review from prameshj August 19, 2022 21:01
@renkelvin renkelvin self-requested a review August 22, 2022 19:01
@prameshj prameshj changed the title Parijat feature2master totp Add public methods to support TOTP as a multi-factor provider. Aug 30, 2022
@bhparijat bhparijat force-pushed the parijat-feature2master-totp branch from 0a02e0a to 791fca2 Compare August 30, 2022 22:45
@bhparijat bhparijat force-pushed the parijat-feature2master-totp branch from 791fca2 to 8bade53 Compare August 30, 2022 23:17
@bhparijat bhparijat merged commit c2353b4 into mfa-totp Aug 31, 2022
@bhparijat bhparijat deleted the parijat-feature2master-totp branch August 31, 2022 20:14
prameshj pushed a commit that referenced this pull request Sep 1, 2022
@bhparijat @prameshj
adding support TOTP MFA (#6547)
297ce99 
Co-authored-by: Parijat Bhatt <[email protected]>
prameshj pushed a commit that referenced this pull request Sep 12, 2022
@bhparijat @prameshj
adding support TOTP MFA (#6547)
bbd0e8e 
Co-authored-by: Parijat Bhatt <[email protected]>
prameshj pushed a commit that referenced this pull request Sep 12, 2022
@bhparijat @prameshj
adding support TOTP MFA (#6547)
8d13c4e 
Co-authored-by: Parijat Bhatt <[email protected]>
prameshj pushed a commit that referenced this pull request Sep 13, 2022
@bhparijat @prameshj
adding support TOTP MFA (#6547)
b012cae 
Co-authored-by: Parijat Bhatt <[email protected]>
prameshj pushed a commit that referenced this pull request Sep 16, 2022
@bhparijat @prameshj
adding support TOTP MFA (#6547)
2c32119 
Co-authored-by: Parijat Bhatt <[email protected]>
prameshj pushed a commit that referenced this pull request Sep 16, 2022
@bhparijat @prameshj
adding support TOTP MFA (#6547)
5a3f79f 
Co-authored-by: Parijat Bhatt <[email protected]>
bhparijat added a commit that referenced this pull request Sep 23, 2022
@bhparijat
adding support TOTP MFA (#6547)
c3fa965 
Co-authored-by: Parijat Bhatt <[email protected]>
bhparijat added a commit that referenced this pull request Sep 23, 2022
@bhparijat
adding support TOTP MFA (#6547)
3b84db4 
Co-authored-by: Parijat Bhatt <[email protected]>
@firebase firebase locked and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prameshj prameshj prameshj approved these changes

@renkelvin renkelvin renkelvin approved these changes

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

@egilmorez egilmorez Awaiting requested review from egilmorez

@erikeldridge erikeldridge Awaiting requested review from erikeldridge

@jposuna jposuna Awaiting requested review from jposuna

@yoyomyo yoyomyo Awaiting requested review from yoyomyo

@zwu52 zwu52 Awaiting requested review from zwu52

@jsdt jsdt Awaiting requested review from jsdt

@allspain allspain Awaiting requested review from allspain

@maneesht maneesht Awaiting requested review from maneesht

@jmwski jmwski Awaiting requested review from jmwski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhparijat @google-oss-bot @prameshj @renkelvin @sam-gc