Skip to content

compile protos and upload the generated json file #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 140 additions & 0 deletions packages/firestore/src/protos/protos.json
Original file line number Diff line number Diff line change
Expand Up @@ -919,6 +919,15 @@
"ruby_package": "Google::Cloud::Firestore::V1"
},
"nested": {
"AggregationResult": {
"fields": {
"aggregateFields": {
"keyType": "string",
"type": "Value",
"id": 2
}
}
},
"DocumentMask": {
"fields": {
"fieldPaths": {
Expand Down Expand Up @@ -1269,6 +1278,29 @@
}
]
},
"RunAggregationQuery": {
"requestType": "RunAggregationQueryRequest",
"responseType": "RunAggregationQueryResponse",
"responseStream": true,
"options": {
"(google.api.http).post": "/v1/{parent=projects/*/databases/*/documents}:runAggregationQuery",
"(google.api.http).body": "*",
"(google.api.http).additional_bindings.post": "/v1/{parent=projects/*/databases/*/documents/*/**}:runAggregationQuery",
"(google.api.http).additional_bindings.body": "*"
},
"parsedOptions": [
{
"(google.api.http)": {
"post": "/v1/{parent=projects/*/databases/*/documents}:runAggregationQuery",
"body": "*",
"additional_bindings": {
"post": "/v1/{parent=projects/*/databases/*/documents/*/**}:runAggregationQuery",
"body": "*"
}
}
}
]
},
"PartitionQuery": {
"requestType": "PartitionQueryRequest",
"responseType": "PartitionQueryResponse",
Expand Down Expand Up @@ -1760,6 +1792,63 @@
}
}
},
"RunAggregationQueryRequest": {
"oneofs": {
"queryType": {
"oneof": [
"structuredAggregationQuery"
]
},
"consistencySelector": {
"oneof": [
"transaction",
"newTransaction",
"readTime"
]
}
},
"fields": {
"parent": {
"type": "string",
"id": 1,
"options": {
"(google.api.field_behavior)": "REQUIRED"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto3 deprecated the "required". This should be a tag only, wouldn't have any side effects, right? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what effects it has, to be honest. But it is definitely different from proto2's "required" keyword. You can just assume it's correct since it's used elsewhere in the protos.

}
},
"structuredAggregationQuery": {
"type": "StructuredAggregationQuery",
"id": 2
},
"transaction": {
"type": "bytes",
"id": 4
},
"newTransaction": {
"type": "TransactionOptions",
"id": 5
},
"readTime": {
"type": "google.protobuf.Timestamp",
"id": 6
}
}
},
"RunAggregationQueryResponse": {
"fields": {
"result": {
"type": "AggregationResult",
"id": 1
},
"transaction": {
"type": "bytes",
"id": 2
},
"readTime": {
"type": "google.protobuf.Timestamp",
"id": 3
}
}
},
"PartitionQueryRequest": {
"oneofs": {
"queryType": {
Expand Down Expand Up @@ -2296,6 +2385,57 @@
}
}
},
"StructuredAggregationQuery": {
"oneofs": {
"queryType": {
"oneof": [
"structuredQuery"
]
}
},
"fields": {
"structuredQuery": {
"type": "StructuredQuery",
"id": 1
},
"aggregations": {
"rule": "repeated",
"type": "Aggregation",
"id": 3
}
},
"nested": {
"Aggregation": {
"oneofs": {
"operator": {
"oneof": [
"count"
]
}
},
"fields": {
"count": {
"type": "Count",
"id": 1
},
"alias": {
"type": "string",
"id": 7
}
},
"nested": {
"Count": {
"fields": {
"upTo": {
"type": "int32",
"id": 1
}
}
}
}
}
}
},
"Cursor": {
"fields": {
"values": {
Expand Down