Skip to content

Fix search/replace for CDN bundles #6474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2022
Merged

Fix search/replace for CDN bundles #6474

merged 3 commits into from
Jul 25, 2022

Conversation

hsubox76
Copy link
Contributor

Make sure it's looking for just the string @firebase/app by putting quote capture groups on either side.
Fixes #6471

@hsubox76 hsubox76 requested a review from dwyfrequency as a code owner July 25, 2022 18:14
@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

⚠️ No Changeset found

Latest commit: 8b82847

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase

    11 size changes

    TypeBase (8260149)Merge (34a3ffc)Diff
    firebase-analytics.js115 kB115 kB-86 B (-0.1%)
    firebase-app-check.js91.0 kB90.9 kB-129 B (-0.1%)
    firebase-app.js87.6 kB87.4 kB-172 B (-0.2%)
    firebase-auth.js418 kB418 kB-43 B (-0.0%)
    firebase-database.js606 kB606 kB-129 B (-0.0%)
    firebase-firestore-lite.js267 kB267 kB-172 B (-0.1%)
    firebase-firestore.js845 kB845 kB-172 B (-0.0%)
    firebase-functions.js32.1 kB32.0 kB-43 B (-0.1%)
    firebase-installations.js59.7 kB59.6 kB-86 B (-0.1%)
    firebase-performance.js123 kB123 kB-86 B (-0.1%)
    firebase-remote-config.js113 kB113 kB-43 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yfkySvuxSp.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (8260149) and merge commit (34a3ffc).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mu1cmcFsSn.html

dwyfrequency
dwyfrequency approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 33d865d into master Jul 25, 2022
@hsubox76 hsubox76 deleted the ch-fix-gulp branch July 25, 2022 21:48
dconeybe pushed a commit that referenced this pull request Jul 26, 2022
@hsubox76 @dconeybe
Fix search/replace for CDN bundles (#6474)
e778f48
@firebase firebase locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[App Check] wrong urls in gstatic file
3 participants
@hsubox76 @google-oss-bot @dwyfrequency